Repository navigation
test(ffe): enable PHP CDN coverage in existing agentless scenario - #8475
Open
leoromanovsky wants to merge 5 commits into
Open
leoromanovsky wants to merge 5 commits into
leoromanovsky wants to merge 5 commits into
Conversation
Contributor
|
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 5 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 209af16 | Docs | View more details | Give us feedback! |
This was referenced Nov 12, 2026
leoromanovsky
marked this pull request as ready for review
November 13, 2026 01:49
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
greghuels
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PHP requires
DD_FEATURE_FLAGS_CONFIGURATION_SOURCE=agentless, so the existing implicit-activation test does not cover PHP's CDN configuration loading.Changes
Enable PHP CDN coverage from
v1.28.0-devusing the existingAGENTLESS_DIRECTscenario. Keep the implicit-activation test for other SDKs and preserve PHP's Laravel/Symfony exclusions. Exposure and evaluation-count coverage is enabled separately in #8476.Validated locally on Apache/PHP 8.2.35 with PHP
ec428b112: the CDN test passed, and all three tests passed with #8476 applied. These runs used system-testsfbb308d318plus #8476's7f153aa229, with-Ffor the local 1.27.0 version label. PHP-FPM and shutdown coverage were not run.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟