Skip to content

test(ffe): enable PHP CDN coverage in existing agentless scenario - #8475

Open
leoromanovsky wants to merge 5 commits into
mainfrom
leo/php-agentless-activation-20261112
Open

leoromanovsky wants to merge 5 commits into
mainfrom
leo/php-agentless-activation-20261112

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

PHP requires DD_FEATURE_FLAGS_CONFIGURATION_SOURCE=agentless, so the existing implicit-activation test does not cover PHP's CDN configuration loading.

Changes

Enable PHP CDN coverage from v1.28.0-dev using the existing AGENTLESS_DIRECT scenario. Keep the implicit-activation test for other SDKs and preserve PHP's Laravel/Symfony exclusions. Exposure and evaluation-count coverage is enabled separately in #8476.

Validated locally on Apache/PHP 8.2.35 with PHP ec428b112: the CDN test passed, and all three tests passed with #8476 applied. These runs used system-tests fbb308d318 plus #8476's 7f153aa229, with -F for the local 1.27.0 version label. PHP-FPM and shutdown coverage were not run.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
    • Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/system-tests-reviewers
tests/ffe/test_agentless_configuration.py                               @DataDog/feature-flagging-and-experimentation-sdk
tests/test_the_test/scenarios.json                                      @DataDog/system-tests-reviewers
tests/test_the_test/test_compute_libraries_and_scenarios.py             @DataDog/system-tests-reviewers

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 5 Pipeline jobs failed

DDCI - DataDog/system-tests | system_tests_build_python_flask-poc — 🔧 Needs a code fix, caused by this PR

View more details · View in DDCI

Testing the test | System Tests (golang, prod) / End-to-end #1 / chi 1 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

DataDog/system-tests | system_tests_build_python_flask-poc

View more details · View in GitLab

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 209af16 | Docs | View more details | Give us feedback!

@leoromanovsky leoromanovsky removed the crucible: reviewing A Crucible review has started; this PR has reviewer attention. label Nov 13, 2026
@leoromanovsky leoromanovsky changed the title test(ffe): activate explicit agentless configuration for PHP test(ffe): enable PHP CDN coverage in existing agentless scenario Nov 13, 2026
@leoromanovsky
leoromanovsky marked this pull request as ready for review November 13, 2026 01:49
@leoromanovsky
leoromanovsky requested review from a team as code owners November 13, 2026 01:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T01:51:36.202094Z 209af16 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants