Skip to content

fix(wall): hold the PCP holder in a Global, not a Persistent #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szegedi merged 1 commit into from
Aug 7, 2026
+1 −6
Merged

fix(wall): hold the PCP holder in a Global, not a Persistent #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions bindings/profilers/wall.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ class PersistentContextPtr {

// Weak handle on the holder object. Owns this PCP: when V8 collects the
// holder, WeakCallback deletes us.
v8::Persistent<v8::Object> handle_;
v8::Global<v8::Object> handle_;

friend class WallProfiler;

Expand Down Expand Up @@ -214,11 +214,6 @@ PersistentContextPtr::~PersistentContextPtr() {
if (next_ != nullptr) next_->pprev_ = pprev_;
profiler_->recordContextRelease();
}
// Cancels the weak callback when we're deleted by ~WallProfiler rather than
// by V8; a no-op when we got here from WeakCallback itself. The holder
// object's internal field is left dangling either way, but nothing reads it
// once the owning profiler is gone.
handle_.Reset();
}

// Maximum number of rounds in the GetV8ToEpochOffset
Expand Down
Loading