Skip to content

Fix the broken remote symbolication link in README.md - #994

Open
rkennke wants to merge 1 commit into
mainfrom
rkennke/PROF-16652-readme-symbolication-link
Open

rkennke wants to merge 1 commit into
mainfrom
rkennke/PROF-16652-readme-symbolication-link

Conversation

@rkennke

@rkennke rkennke commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?:

Fixes the remote symbolication link in README.md. It pointed to doc/plans/RemoteSymbolication.md, which does not exist, and its text named a third path. The link target and its text now both name doc/reference/RemoteSymbolication.md.

Motivation:

A reader who followed the link got a 404.

Additional Notes:

  • A scan of every relative Markdown link in README.md and doc/ found no other broken target.
  • The change was built, reviewed and tested with the new build-test-review skill (Add a build-test-review skill for accepted PROF designs #993), as its first real run.
  • Review: /code-review medium (docs row), fresh context: no findings.
  • Human review: none required beyond the usual approval; docs only.

How to test the change?:

Check Result
Every relative Markdown link in README.md resolves; the link text equals its target passed: all 7 links point to existing files
./gradlew :ddprof-lib:qualityChecks passed
A fresh agent session on a clean clone, asked where README.md sends a reader for remote symbolication details and to summarize that page passed: it opened doc/reference/RemoteSymbolication.md, and its summary matches the page

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a security review (run the dd:platform-security-review
    skill, or file a request via the PSEC review form).
    bewaire also runs automatically on every PR.
  • This PR doesn't touch any of that.
  • JIRA: PROF-16652

🤖 Generated with Claude Code

…OF-16652)

The link targeted doc/plans/RemoteSymbolication.md, which does not exist,
and its text named a third path. Both now name
doc/reference/RemoteSymbolication.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rkennke
rkennke requested a review from a team as a code owner November 13, 2026 16:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T16:01:13.345531Z 5b37655 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The corrected README link resolves to the existing remote symbolication document, and its displayed path matches the target.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 5b37655

@dd-octo-sts

dd-octo-sts Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Scan-Build Report

User:runner@runnervmccnms
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 all
Clang Version:Ubuntu clang version 21.1.8 (6ubuntu1)
Date:Fri Nov 13 16:02:29 2026

Bug Summary

Bug TypeQuantityDisplay?
All Bugs2
Logic error
Dereference of null pointer1
Unused code
Dead initialization1

Filter Results by File

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Unused codeDead initializationreferenceChains.cppapplyOomRamp4971
Logic errorDereference of null pointerperfEvents_linux.cppunregisterThread72026

@dd-octo-sts

dd-octo-sts Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #43458247175 | Commit: ea2bfaf | Duration: 21m 24s (longest job)

✅ All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - ✅ - -
8-ibm - ✅ - -
8-j9 ✅ ✅ - -
8-librca - - ✅ ✅
8-orcl - ✅ - -
11 - ✅ - -
11-j9 ✅ ✅ - -
11-librca - - ✅ ✅
17 ✅ ✅ - -
17-graal ✅ ✅ - -
17-j9 ✅ ✅ - -
17-librca - - ✅ ✅
21 ✅ ✅ - -
21-graal ✅ ✅ - -
21-librca - - ✅ ✅
25 ✅ ✅ - -
25-graal ✅ ✅ - -
25-librca - - ✅ ✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-11-13 16:24:13 UTC

@dd-octo-sts

dd-octo-sts Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

✅ All 40 integration tests passed

📊 Dashboard · 👷 Pipeline · 📦 5b37655e

@datadog-prod-us1-5

Copy link
Copy Markdown
Contributor

Pipelines

⚠️ Warnings

Your PR has warnings. Please review the issues below.

🚦 1 Pipeline job failed

DDCI - DataDog/java-profiler | renaissance-benchmarks: [naive-bayes, 25] — 🔄 Retry may pass, looks flaky

View more details · View in DDCI

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5b37655 | Docs | View more details | Give us feedback!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant