Repository navigation
Fix CI on the ubuntu-26.04 and Windows runner images - #337
Merged
Merged
Conversation
ubuntu-latest now resolves to ubuntu-26.04, which has no CRuby builds older than 2.3, so run 2.1 and 2.2 on ubuntu-24.04 instead. Bump ruby/setup-ruby to v1.338.0. v1.335.0 downloads the mingw64 msys2 toolchain for Ruby 2.4-3.0 on Windows from the latest setup-msys2-gcc release, which no longer ships it (404); newer versions pin a tagged release that does.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
corsonknowles
force-pushed
the
fix-ci-runner-images
branch
from
November 10, 2026 07:59
5bf0d8a to
d320d8b
Compare
Contributor
Author
|
Thanks Codex! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two runner-image changes broke 7 jobs in the
Ruby Testmatrix onmaster. Every failure happens inruby/setup-ruby, before any spec runs. This PR fixes both.ubuntu: Ruby 2.1 and 2.2
ubuntu-latestis moving from 24.04 to 26.04. ruby-builder publishes 26.04 builds only for CRuby 2.3 and later (ruby/setup-ruby#954), so these jobs fail with:This PR excludes those two from
ubuntu-latestand runs them onubuntu-24.04instead. Both builds exist there (the release assets return 200). 2.3 and later stay onubuntu-latest.windows: Ruby 2.4 through 3.0
These Rubies use the
mingw64msys2 toolchain.setup-rubyv1.335.0 downloads it fromsetup-msys2-gcc/releases/latest/download/..., but the latest release no longer shipsmingw64assets, so the download 404s:In v1.338.0,
windows-toolchain-versions.jsonpins those Rubies to a tagged release (v20261024.010459) that still has the asset. This PR bumps the pin to v1.338.0 (commitb3aacea, still SHA-pinned). The bump also brings in v1.337.0, which tests 2.4–3.1 on ubuntu-26.04.Change
.github/workflows/test.ymlonly. No library or spec changes.