Repository navigation
Add RubyGems trusted publishing - #336
Merged
Merged
Conversation
Base the manual publishing workflow on `libdatadog-rb`, using `rubygems/release-gem` and the existing Bundler release task. Restrict publishing to `master` through the `rubygems.org` environment. Use OIDC for RubyGems credentials and Octo STS for release tag pushes, so publishing needs no long-lived API keys. Document publisher setup and the release procedure.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Update `ruby/setup-ruby` to v1.335.0, which also searches Git’s `ucrt64` certificate directory. The previous pin only checked the `mingw64` paths, failing during DevKit setup for Ruby 2.1–2.3.
Let `ruby/setup-ruby` install dependencies through `bundler-cache`. The redundant install step uses `--with`, which Bundler 4 removed. Development dependencies are included by default. Quote Ruby matrix versions so `3.0` remains a minor version rather than becoming `3` and selecting the latest Ruby 3 release.
Add Ruby 4.0 to the Linux, macOS, and Windows test matrix. Declare `logger` and `irb` as test dependencies on Ruby 4.0 and newer, where they are no longer default gems.
Reline requires `fiddle/import` for its Windows backend when FakeFS loads IRB. Declare `fiddle` alongside the other former default gems so the Ruby 4.0 Windows suite can load.
StephenWakely
requested changes
Nov 3, 2026
StephenWakely
left a comment
StephenWakely
left a comment
Contributor
There was a problem hiding this comment.
Presumably we want to still create GitHub releases when releasing as well. Would it be possible to either add a release task to the workflow or include the details in RELEASING.md?
Create a GitHub release after publishing to RubyGems, using the same version tag and the gem built by the release task. Require the tag to exist so release creation cannot tag a different commit. Generate release notes and document the GitHub release output.
Member
Author
|
Addressed by 74b7f64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterand therubygems.orgenvironment.rubygems/release-gemand the existing Bundler release task to build, tag, and publish the gem.Validation