Skip to content

[EX-3939] Document experiment holdouts - #41141

Open
tbuffington7 wants to merge 29 commits into
masterfrom
tbuffington7/EX-3939-holdout-documentation
Open

tbuffington7 wants to merge 29 commits into
masterfrom
tbuffington7/EX-3939-holdout-documentation

Conversation

@tbuffington7

@tbuffington7 tbuffington7 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

Document how holdouts measure the combined effect of shipped changes. Cover setup, inclusion and analysis phases, exposure rules, and warehouse exposure models. Link the guide from experiment concepts, launch instructions, and results.

EX-3939

Merge readiness

  • Ready for merge

AI assistance

Used Codex to draft and revise the documentation, review the changes, and run checks.

For Datadog employees:

  • Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR.
  • New: Comment with /review to run an automated check that catches common issues before a Documentation team member reviews your PR.

Additional notes

Validation:

  • Vale 3.9.1: no findings on added lines.
  • Repository pre-commit checks passed.
  • Frontmatter, local links, section anchors, and SQL example checks passed.
  • Four independent reviews completed.

The SQL example was checked with a local fixture, not a live warehouse.

@tbuffington7
tbuffington7 marked this pull request as ready for review October 28, 2026 17:21
@tbuffington7
tbuffington7 requested a review from a team as a code owner October 28, 2026 17:21
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
tbuffington7 and others added 2 commits October 28, 2026 10:47
Co-authored-by: Danyal Khan <50880807+danyal002@users.noreply.github.com>
Co-authored-by: Danyal Khan <50880807+danyal002@users.noreply.github.com>
@maycmlee

Copy link
Copy Markdown
Contributor

Created DOCS-16171 for review.

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review label Oct 28, 2026

@git-thuerk-done git-thuerk-done left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting holdouts! My main feedback is about navigation, structure, and repetition. Line-level suggestions are inline.

BLOCKING --> Add the page to the left nav under Concepts. experiments/holdouts doesn't have an entry in hugo/config/_default/menus/main.en.yaml, so it publishes without a left-nav link. The Concepts page already links to it, so nest it under Concepts, after Cumulative Impact:

    - name: Holdouts
      url: experiments/holdouts/
      parent: pa_experiments_concepts
      identifier: pa_experiments_holdouts
      weight: 5

Front-load requirements. The main constraints (Datadog Feature Flags, the same subject type, and a consistent subject ID on line 23, plus the Eligible experiments list on line 95) appear after a lot of concept material and after setup starts. Consider a short Requirements section near the top, or at least before Set up a holdout, so readers know right away whether holdouts work for them.

Reduce repetition. The overview (lines 8–21) says "combined effect of shipped changes" three times across several single-sentence paragraphs. Consider merging them into one or two paragraphs plus the two-group list. Across the page, "early directional read" and "both groups receive control until rollout completes" each appear four or five times (lines 21, 57, 61, 65, 81, 133, 149). Explain each idea once, where it fits best, and link to it from other sections.

Otherwise other comments are inline, let me know if you have any questions and when this is ready for re-review!

Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
Comment thread hugo/content/en/experiments/holdouts.md Resolved
@github-actions github-actions Bot added the Architecture Everything related to the Doc backend label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants