appsec: pass PCRE2 includes to xtest tracer build - #4088
Conversation
Forward the PCRE2 include directories discovered by CMake to the Makefile-based ddtrace dependency build used by xtest.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b551d7cf0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set(_DD_APPSEC_DDTRACE_MAKE_OPTIONS | ||
| "EXTRA_CFLAGS=${_DD_APPSEC_PCRE2_CPPFLAGS}") |
There was a problem hiding this comment.
When PCRE2 has an external include directory, passing EXTRA_CFLAGS=... as a make command-line variable propagates through the recursive $(MAKE) -C $(BUILD_DIR) invocation and overrides the generated build Makefile's EXTRA_CFLAGS rather than extending it. Consequently, flags selected by config.m4, including -fvisibility=hidden and sanitizer instrumentation such as -fsanitize=address, are dropped from the xtest tracer build; in an ASAN environment this can make the tests run against an uninstrumented tracer. Append the include path without overriding the configure-generated value.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
changed to EXTRA_INCLUDES, which kind of has the same problem but is not being used at this point
|
2 participants
Forward the PCRE2 include directories discovered by CMake to the Makefile-based ddtrace dependency build used by xtest.
Description
Reviewer checklist