Resolve the Feature Flags settings like the SDK by PerfectSlayer · Pull Request #12977 · DataDog/dd-trace-java

PerfectSlayer · 2026-10-21T11:54:33Z

What Does This Do

Resolves the Feature Flags settings in the agent like the dd-openfeature SDK does:

Moves the Feature Flags settings to dd-trace-api and removes the feature-flagging-config module.
Exposes the configuration source as an enum, parsed case insensitively without trimming, like the SDK.
Adds ConfigurationResolutionParityTest, checking the agent and the SDK resolve enablement and source alike, including padded values.
Passes the resolved enablement and source to the SDK through the agent bridge, and installs the bridge even when the agent configuration disables Feature Flags: the bridge then reports them disabled (DisabledAgentBridge), as the SDK cannot read every agent configuration source (stable configuration, configuration file).

Motivation

The agent and the SDK must agree on the configuration source (APMLP-1512). Done after the compatibility PR: released SDKs read the old settings class from the agent until they are guarded.

Additional Notes

No change to the supported values. A disable set only in an agent configuration source the SDK cannot read now keeps the SDK disabled instead of starting it agentless.

Stack

The full change is in #12709. It was split into this stack to ease the review.

Jira ticket: APMLP-1512

🤖 Generated with Claude Code

dd-octo-sts · 2026-10-21T12:16:04Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.85 s	14.70 s	[+0.1%; +2.0%] (maybe worse)
startup:insecure-bank:tracing:Agent	13.60 s	13.75 s	[-1.9%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent	17.14 s	17.00 s	[+0.1%; +1.6%] (maybe worse)
startup:petclinic:iast:Agent	17.01 s	16.62 s	[-2.5%; +7.2%] (no difference)
startup:petclinic:profiling:Agent	16.57 s	17.00 s	[-3.5%; -1.6%] (significantly better)
startup:petclinic:sca:Agent	17.03 s	17.01 s	[-0.8%; +1.0%] (no difference)
startup:petclinic:tracing:Agent	16.22 s	16.13 s	[-0.3%; +1.4%] (no difference)

Commit: 000b6e2f · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

chatgpt-codex-connector · 2026-10-22T11:36:07Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T11:39:35.160424Z	`bbdf441`	Draft marked ready
🔒 Security Review	✅ Completed 2026-10-22T11:38:53.197456Z	`bbdf441`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadog-datadog-prod-us1

More details

The settings retain their existing keys and parsing behavior, and repository callers are consistently updated for the enum return type.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit bbdf441}

sarahchen6

Looks good!

datadog-datadog-prod-us1

The new event proxy can replay ambiguously delivered batches and permanently disable event delivery after failed startup discovery. Proxy origin metadata and Remote Configuration error acknowledgements also regress.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 994142b}

Findings that could not be posted inline

products/feature-flagging/feature-flagging-lib/src/main/java/com/datadog/featureflag/EventProxy.java:81

[P2] Recover event delivery after failed startup discovery

If the Datadog Agent is unreachable during SDK initialization, discovery can return null clients, but resolved permanently caches that failure. JavaAgentBridge then returns no transport, and FeatureFlagsRuntime omits both event pipelines when direct fallback is unavailable. Agent recovery can restore flag configuration while event delivery remains disabled until runtime recreation. Recovery requires preserving a transport and retrying discovery, not merely resetting this flag.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means

👍 Useful: correct, and you're fixing it or will.
👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
😕 Unclear: you can't tell what it means or why it matters.
👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

_{🤖 Bits Code Review} _{· Open Bits AI session}

products/feature-flagging/feature-flagging-lib/src/main/java/com/datadog/featureflag/RemoteConfigServiceImpl.java:44

[P2] Report rejected flag configurations as apply errors

For a malformed FFE_FLAGS document, this identity deserializer succeeds while the SDK's RemoteConfigurationService catches the parsing failure and returns normally. ProductState therefore reports APPLY_STATE_ACKNOWLEDGED although the SDK rejected the update and retained its previous configuration. The former parser propagated these failures as errors. Preserve a validation-error path through the SDK and bridge to the poller.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means

👍 Useful: correct, and you're fixing it or will.
👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
😕 Unclear: you can't tell what it means or why it matters.
👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

_{🤖 Bits Code Review} _{· Open Bits AI session}

PerfectSlayer · 2026-10-23T13:22:27Z

[P2] Recover event delivery after failed startup discovery (EventProxy.java:81)

#12978 removes the cached discovery failure: the Remote Configuration route uses the fixed EVP v2 endpoint, and the agentless route without direct intake rediscovers the proxy at most once a minute. isAvailable() stays true when direct intake isn't available, so the SDK keeps both event pipelines.

PerfectSlayer · 2026-10-23T14:24:03Z

[P2] Report rejected flag configurations as apply errors (RemoteConfigServiceImpl.java:44)

#12978 reports them as apply errors again: the SDK RemoteConfigurationService rejects a malformed document by throwing instead of dropping it, and RemoteConfigServiceImpl.accept rethrows the first subscriber failure once every subscriber is notified, so the poller marks the FFE_FLAGS config as not applied. The bridge.v1 ConfigurationSource contract documents the rejection.

datadog-datadog-prod-us1

More details

The bridge explicitly conveys agent-side disables to the SDK, including settings from configuration sources the SDK cannot read. The completed static review identified no reportable regression; runtime behavior remains unverified.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 6ca9473}

Move the Feature Flags settings to dd-trace-api, remove the feature-flagging-config module, and expose the configuration source as an enum parsed like the SDK does. Check the agent and the SDK resolve the settings alike. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…idge

…e SDK The bridge was only installed when the agent enabled Feature Flags, so when only an agent configuration source the SDK cannot read (stable configuration, configuration file) disabled them, the SDK fell back to its own settings and started agentless. The bridge is now installed regardless, and reports Feature Flags as disabled when the agent configuration disables them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

PerfectSlayer added tag: no release notes Changes to exclude from release notes type: refactoring tag: ai generated Largely based on code generated by an AI or LLM comp: openfeature OpenFeature labels Oct 21, 2026

PerfectSlayer added this pull request to stack #12979 October 21, 2026 11:59

PerfectSlayer removed this pull request from stack #12979 October 21, 2026 12:00

PerfectSlayer added this pull request to stack #12980 October 21, 2026 12:04

This comment has been minimized.

Sign in to view

PerfectSlayer force-pushed the bbujon/ffe-settings branch from a0b4cb0 to 13f62ff Compare October 21, 2026 14:08

PerfectSlayer force-pushed the bbujon/ffe-settings branch from 13f62ff to 918c24c Compare October 21, 2026 14:19

PerfectSlayer force-pushed the bbujon/ffe-settings branch from 918c24c to 4489a78 Compare October 21, 2026 14:30

PerfectSlayer force-pushed the bbujon/ffe-settings branch from 4489a78 to 2605ead Compare October 22, 2026 08:18

PerfectSlayer force-pushed the bbujon/ffe-settings branch from 2605ead to cf0d03a Compare October 22, 2026 08:41

PerfectSlayer force-pushed the bbujon/ffe-settings branch from cf0d03a to 6c85344 Compare October 22, 2026 11:01

PerfectSlayer force-pushed the bbujon/ffe-settings branch 2 times, most recently from e22560c to bbdf441 Compare October 22, 2026 11:30

PerfectSlayer marked this pull request as ready for review October 22, 2026 11:35

PerfectSlayer requested a review from ygree October 22, 2026 11:36

datadog-datadog-prod-us1 Bot reviewed Oct 22, 2026

View reviewed changes

sarahchen6 force-pushed the bbujon/ffe-settings branch from 9039dab to 1b3a770 Compare October 22, 2026 22:20

sarahchen6 approved these changes Oct 22, 2026

View reviewed changes

PerfectSlayer requested a review from a team as a code owner October 23, 2026 09:15

PerfectSlayer requested review from randomanderson and removed request for a team October 23, 2026 09:15

PerfectSlayer force-pushed the bbujon/ffe-settings branch from 994142b to cd834fd Compare October 23, 2026 09:16

datadog-datadog-prod-us1 Bot reviewed Oct 23, 2026

View reviewed changes

Comment thread ...flagging/feature-flagging-lib/src/main/java/com/datadog/featureflag/FeatureFlagsBackend.java

datadog-datadog-prod-us1 Bot reviewed Oct 23, 2026

View reviewed changes

Comment thread ...flagging/feature-flagging-lib/src/main/java/com/datadog/featureflag/FeatureFlagsBackend.java

datadog-datadog-prod-us1 Bot reviewed Oct 23, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot force-pushed the bbujon/ffe-settings branch from cd834fd to c888b07 Compare October 23, 2026 12:46

ygree approved these changes Oct 23, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot force-pushed the bbujon/ffe-settings branch from 46270f2 to 6ca9473 Compare October 26, 2026 14:59

Base automatically changed from bbujon/ffe-compat to master October 26, 2026 19:02

datadog-datadog-prod-us1 Bot reviewed Oct 26, 2026

View reviewed changes

PerfectSlayer and others added 4 commits October 27, 2026 09:52

chore(ffe): Own the Feature Flags settings in dd-trace-api

c115702

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(ffe): Expose resolved Feature Flags settings through the agent br…

4b4e765

…idge

PerfectSlayer force-pushed the bbujon/ffe-settings branch from 6ca9473 to 000b6e2 Compare October 27, 2026 08:55

gh-worker-dd-mergequeue-cf854d Bot merged commit ea2ce3f into master Oct 27, 2026
608 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/ffe-settings branch October 27, 2026 15:18

github-actions Bot added this to the 1.69.0 milestone Oct 27, 2026

Navigation Menu

Repository navigation

Resolve the Feature Flags settings like the SDK - #12977

Resolve the Feature Flags settings like the SDK#12977
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
bbujon/ffe-settings

PerfectSlayer commented Oct 21, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Uh oh!

sarahchen6 left a comment

Uh oh!

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Uh oh!

PerfectSlayer commented Oct 23, 2026

Uh oh!

PerfectSlayer commented Oct 23, 2026

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

PerfectSlayer commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Stack

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Choose a reason for hiding this comment

Findings that could not be posted inline

Uh oh!

PerfectSlayer commented Oct 23, 2026

Uh oh!

PerfectSlayer commented Oct 23, 2026

Uh oh!

datadog-datadog-prod-us1 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PerfectSlayer commented Oct 21, 2026 •

edited

Loading

dd-octo-sts Bot commented Oct 21, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading