Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6680c2b
Fix JSON span event encoding in v1 payloads
AlexeyKuznetsov-DD Jul 29, 2026
ffe6112
Enable `v1` by default to run the tests on CI.
AlexeyKuznetsov-DD Jul 29, 2026
e875817
Merge branch 'master' into alexeyk/fix-v1-span-events-json-encoding-v…
AlexeyKuznetsov-DD Jul 30, 2026
0f351ca
Debug SSI system-tests
AlexeyKuznetsov-DD Jul 30, 2026
707372a
Debug SSI system-tests
AlexeyKuznetsov-DD Jul 30, 2026
f707cb8
Debug SSI system-tests: actual fix
AlexeyKuznetsov-DD Jul 30, 2026
7d2c4af
Merge branch 'master' into alexeyk/fix-v1-span-events-json-encoding
AlexeyKuznetsov-DD Jul 30, 2026
4ffbbd0
Merge branch 'alexeyk/fix-v1-span-events-json-encoding' into alexeyk/…
AlexeyKuznetsov-DD Jul 30, 2026
912f05b
Merge branch 'master' into alexeyk/fix-v1-span-events-json-encoding-v…
AlexeyKuznetsov-DD Jul 31, 2026
7760dee
Test with systemt-test from master.
AlexeyKuznetsov-DD Jul 31, 2026
314a2c6
Test the latest fix in system-tests.
AlexeyKuznetsov-DD Aug 1, 2026
ed1e432
Test the latest fix in system-tests.
AlexeyKuznetsov-DD Aug 1, 2026
66fadfb
Merge branch 'master' into alexeyk/fix-v1-span-events-json-encoding-v…
AlexeyKuznetsov-DD Aug 3, 2026
a69117d
Test v1 on master.
AlexeyKuznetsov-DD Aug 3, 2026
26e1302
Merge branch 'master' into alexeyk/fix-v1-span-events-json-encoding-v…
AlexeyKuznetsov-DD Aug 4, 2026
445fb36
Merge branch 'master' into alexeyk/fix-v1-span-events-json-encoding-v…
AlexeyKuznetsov-DD Aug 4, 2026
367fa34
Merge branch 'master' into alexeyk/fix-v1-span-events-json-encoding-v…
AlexeyKuznetsov-DD Aug 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import static datadog.communication.http.OkHttpUtils.msgpackRequestBodyOf;
import static datadog.communication.http.OkHttpUtils.prepareRequest;
import static datadog.communication.serialization.msgpack.MsgPackWriter.FIXARRAY;
import static datadog.trace.api.ProtocolVersion.V0_4;
import static datadog.trace.api.ProtocolVersion.V1_0;
import static java.util.Collections.emptyMap;
import static java.util.Collections.emptySet;
import static java.util.Collections.singletonList;
Expand Down Expand Up @@ -118,7 +118,7 @@ public DDAgentFeaturesDiscovery(
this.agentBaseUrl = agentUrl;
this.metricsEnabled = metricsEnabled;
this.ignoreAgentVersionForStats = ignoreAgentVersionForStats;
this.protocolVersion = protocolVersion != null ? protocolVersion : V0_4;
this.protocolVersion = protocolVersion != null ? protocolVersion : V1_0;
this.discoveryTimer = monitoring.newTimer("trace.agent.discovery.time");
this.discoveryState = new State();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class DDAgentFeaturesDiscoveryTest extends DDSpecification {
V1_0 | V1_ENDPOINT
}

def "null protocol version falls back to v0.4 trace endpoints"() {
def "null protocol version falls back to v1.0 trace endpoints"() {
setup:
OkHttpClient client = Mock(OkHttpClient)
DDAgentFeaturesDiscovery features =
Expand All @@ -98,9 +98,10 @@ class DDAgentFeaturesDiscoveryTest extends DDSpecification {

then:
1 * client.newCall({ Request request -> request.url().toString() == "http://localhost:8125/info" }) >> { Request request -> infoResponse(request, "{}") }
1 * client.newCall({ Request request -> request.url().toString() == "http://localhost:8125/v1.0/traces" }) >> { Request request -> success(request) }
0 * client.newCall({ Request request -> request.url().toString() == "http://localhost:8125/v0.5/traces" }) >> { Request request -> success(request) }
1 * client.newCall({ Request request -> request.url().toString() == "http://localhost:8125/v0.4/traces" }) >> { Request request -> success(request) }
features.getTraceEndpoint() == V04_ENDPOINT
0 * client.newCall({ Request request -> request.url().toString() == "http://localhost:8125/v0.4/traces" }) >> { Request request -> success(request) }
features.getTraceEndpoint() == V1_ENDPOINT
0 * _
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public final class ConfigDefaults {
Arrays.asList("user.id", "session.id", "account.id");
static final boolean DEFAULT_JMX_FETCH_ENABLED = true;

static final String DEFAULT_TRACE_AGENT_PROTOCOL_VERSION = ProtocolVersion.V0_4.asConfigValue();
static final String DEFAULT_TRACE_AGENT_PROTOCOL_VERSION = ProtocolVersion.V1_0.asConfigValue();

static final boolean DEFAULT_CLIENT_IP_ENABLED = false;

Expand Down