Improve crash report message when signal is absent#11681
Conversation
amarziali
added
type: enhancement
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b117ab3ab7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| kind = sigInfo.name; | ||
| message = "Process terminated by signal " + kind; | ||
| } else { | ||
| kind = "InternalError"; |
There was a problem hiding this comment.
For complete Windows HotSpot crash logs, the siginfo: line uses formats like ExceptionCode=... / EXCEPTION_ACCESS_VIOLATION, which the current SIGINFO_PARSER does not match, so sigInfo remains null even though the crash reason is not an internal VM error. This fallback now reports those access violations as InternalError, hiding the actual crash type in Windows crash reports; only use this label when the header actually indicates Internal Error, or parse the Windows siginfo/header before falling back.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Yes but this looks to me eventually a separate kind of work to do to fill this gap
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
2 participants
What Does This Do
This PR improves the message provided by crashtracking when the termination signal is not known.
Instead of printing:
Process terminated by signal UNKNOWNIs not harmonising this case by surfacing:
Process terminated by Internal error(given Internal Error what usually appearing in the hotspot hs_err)Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]