Ignore capturing connection continuation for armeria

[amarziali]

What Does This Do

Armeria lazily builds its HttpChannelPool on the first request (so the request span is active), and the pool's CompletableFuture close-handler captured that span. It only completes at pool shutdown and the trace stayed pinned for the whole pool lifetime.

Also, netty's ConnectAdvice captures the active span on connect, expecting our http client handler to consume it. Armeria runs its own codec/pipeline, so nothing ever consumed it.

This PR disable capturing continuations for the two cases and rolls back the previous attempt to overhaul largely speaking the netty captures since it had side effects on ratpack.

Motivation

Additional Notes

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Add your completed PR to the merge queue by commenting /merge. You can also:
  • Customize the commit message associated with the merge with /merge --commit-message "..."
  • Remove your PR from the merge queue with /merge -c
  • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
  • Get more information in this doc

Jira ticket: [PROJ-IDENT]

[amarziali]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: c8c4ca807c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.07 s	14.01 s	[-0.7%; +1.6%] (no difference)
startup:insecure-bank:tracing:Agent	12.91 s	12.97 s	[-1.3%; +0.3%] (no difference)
startup:petclinic:appsec:Agent	17.41 s	17.20 s	[+0.1%; +2.3%] (maybe worse)
startup:petclinic:iast:Agent	17.13 s	17.45 s	[-2.8%; -0.9%] (maybe better)
startup:petclinic:profiling:Agent	17.43 s	17.42 s	[-1.1%; +1.2%] (no difference)
startup:petclinic:sca:Agent	17.48 s	16.90 s	[-1.1%; +8.0%] (no difference)
startup:petclinic:tracing:Agent	16.49 s	16.56 s	[-1.5%; +0.7%] (no difference)

Commit: d7fc6b53 · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

[dougqh]

The fix is good as is, but we are drifting into the types of async changes that I feared.

If we adopted the async model that I proposed, this fix would be simpler. ConnectAdvice.OnEnter is a context capture step, it forks the calling context into a continuation expecting a corresponding execute step when the first request is written. For Armeria and reused HTTP/2 connections, no execution ever runs leaving a dangling fork. The consumer attribute is compensating for that.

The proposed context model tolerates unconsumed forks, so cancellation is effectively automatic. Obviously, that's a larger change, but something to consider before we make these changes everywhere.

[amarziali]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 👍

Reviewed commit: d7fc6b5325

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".