Added missing thread metadata in V1 trace mapper.#11227
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom Apr 29, 2026
Merged
Added missing thread metadata in V1 trace mapper.#11227gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070191
Total [baseline] (8.89 s) : 0, 8889639
Agent [candidate] (1.064 s) : 0, 1063749
Total [candidate] (8.843 s) : 0, 8843025
section iast
Agent [baseline] (1.241 s) : 0, 1240531
Total [baseline] (9.479 s) : 0, 9478902
Agent [candidate] (1.249 s) : 0, 1249268
Total [candidate] (9.523 s) : 0, 9523378
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (639.001 ms) : 0, 639001
BytebuddyAgent [candidate] (636.028 ms) : 0, 636028
AgentMeter [baseline] (29.754 ms) : 0, 29754
AgentMeter [candidate] (29.462 ms) : 0, 29462
GlobalTracer [baseline] (250.259 ms) : 0, 250259
GlobalTracer [candidate] (248.647 ms) : 0, 248647
AppSec [baseline] (33.058 ms) : 0, 33058
AppSec [candidate] (32.541 ms) : 0, 32541
Debugger [baseline] (60.412 ms) : 0, 60412
Debugger [candidate] (59.648 ms) : 0, 59648
Remote Config [baseline] (608.049 µs) : 0, 608
Remote Config [candidate] (593.918 µs) : 0, 594
Telemetry [baseline] (9.984 ms) : 0, 9984
Telemetry [candidate] (9.116 ms) : 0, 9116
Flare Poller [baseline] (9.847 ms) : 0, 9847
Flare Poller [candidate] (10.604 ms) : 0, 10604
section iast
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (821.824 ms) : 0, 821824
BytebuddyAgent [candidate] (827.274 ms) : 0, 827274
AgentMeter [baseline] (11.262 ms) : 0, 11262
AgentMeter [candidate] (11.517 ms) : 0, 11517
GlobalTracer [baseline] (236.731 ms) : 0, 236731
GlobalTracer [candidate] (238.854 ms) : 0, 238854
IAST [baseline] (27.462 ms) : 0, 27462
IAST [candidate] (27.628 ms) : 0, 27628
AppSec [baseline] (32.1 ms) : 0, 32100
AppSec [candidate] (32.495 ms) : 0, 32495
Debugger [baseline] (62.038 ms) : 0, 62038
Debugger [candidate] (62.461 ms) : 0, 62461
Remote Config [baseline] (533.082 µs) : 0, 533
Remote Config [candidate] (517.186 µs) : 0, 517
Telemetry [baseline] (7.908 ms) : 0, 7908
Telemetry [candidate] (7.947 ms) : 0, 7947
Flare Poller [baseline] (3.338 ms) : 0, 3338
Flare Poller [candidate] (3.363 ms) : 0, 3363
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063137
Total [baseline] (10.958 s) : 0, 10958056
Agent [candidate] (1.07 s) : 0, 1069657
Total [candidate] (10.932 s) : 0, 10932408
section appsec
Agent [baseline] (1.265 s) : 0, 1265124
Total [baseline] (11.163 s) : 0, 11163323
Agent [candidate] (1.273 s) : 0, 1272990
Total [candidate] (11.13 s) : 0, 11130303
section iast
Agent [baseline] (1.245 s) : 0, 1245470
Total [baseline] (11.212 s) : 0, 11211653
Agent [candidate] (1.241 s) : 0, 1240900
Total [candidate] (11.158 s) : 0, 11158436
section profiling
Agent [baseline] (1.189 s) : 0, 1189081
Total [baseline] (11.024 s) : 0, 11023936
Agent [candidate] (1.187 s) : 0, 1187448
Total [candidate] (11.066 s) : 0, 11066485
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (635.345 ms) : 0, 635345
BytebuddyAgent [candidate] (639.256 ms) : 0, 639256
AgentMeter [baseline] (29.42 ms) : 0, 29420
AgentMeter [candidate] (29.582 ms) : 0, 29582
GlobalTracer [baseline] (248.623 ms) : 0, 248623
GlobalTracer [candidate] (249.634 ms) : 0, 249634
AppSec [baseline] (32.889 ms) : 0, 32889
AppSec [candidate] (32.823 ms) : 0, 32823
Debugger [baseline] (60.3 ms) : 0, 60300
Debugger [candidate] (61.573 ms) : 0, 61573
Remote Config [baseline] (599.608 µs) : 0, 600
Remote Config [candidate] (589.58 µs) : 0, 590
Telemetry [baseline] (12.133 ms) : 0, 12133
Telemetry [candidate] (9.081 ms) : 0, 9081
Flare Poller [baseline] (6.699 ms) : 0, 6699
Flare Poller [candidate] (9.801 ms) : 0, 9801
section appsec
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (674.85 ms) : 0, 674850
BytebuddyAgent [candidate] (680.515 ms) : 0, 680515
AgentMeter [baseline] (12.293 ms) : 0, 12293
AgentMeter [candidate] (12.35 ms) : 0, 12350
GlobalTracer [baseline] (248.799 ms) : 0, 248799
GlobalTracer [candidate] (250.494 ms) : 0, 250494
AppSec [baseline] (185.699 ms) : 0, 185699
AppSec [candidate] (185.756 ms) : 0, 185756
Debugger [baseline] (64.763 ms) : 0, 64763
Debugger [candidate] (64.964 ms) : 0, 64964
Remote Config [baseline] (563.876 µs) : 0, 564
Remote Config [candidate] (559.156 µs) : 0, 559
Telemetry [baseline] (7.745 ms) : 0, 7745
Telemetry [candidate] (7.793 ms) : 0, 7793
Flare Poller [baseline] (6.71 ms) : 0, 6710
Flare Poller [candidate] (5.541 ms) : 0, 5541
IAST [baseline] (24.804 ms) : 0, 24804
IAST [candidate] (24.879 ms) : 0, 24879
section iast
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (824.051 ms) : 0, 824051
BytebuddyAgent [candidate] (819.477 ms) : 0, 819477
AgentMeter [baseline] (11.306 ms) : 0, 11306
AgentMeter [candidate] (11.255 ms) : 0, 11255
GlobalTracer [baseline] (237.682 ms) : 0, 237682
GlobalTracer [candidate] (237.86 ms) : 0, 237860
AppSec [baseline] (33.15 ms) : 0, 33150
AppSec [candidate] (32.463 ms) : 0, 32463
Debugger [baseline] (63.307 ms) : 0, 63307
Debugger [candidate] (63.185 ms) : 0, 63185
Remote Config [baseline] (525.038 µs) : 0, 525
Remote Config [candidate] (526.478 µs) : 0, 526
Telemetry [baseline] (8.005 ms) : 0, 8005
Telemetry [candidate] (7.925 ms) : 0, 7925
Flare Poller [baseline] (3.399 ms) : 0, 3399
Flare Poller [candidate] (3.402 ms) : 0, 3402
IAST [baseline] (26.719 ms) : 0, 26719
IAST [candidate] (27.621 ms) : 0, 27621
section profiling
ProfilingAgent [baseline] (94.126 ms) : 0, 94126
ProfilingAgent [candidate] (93.71 ms) : 0, 93710
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (694.364 ms) : 0, 694364
BytebuddyAgent [candidate] (693.379 ms) : 0, 693379
AgentMeter [baseline] (8.928 ms) : 0, 8928
AgentMeter [candidate] (8.951 ms) : 0, 8951
GlobalTracer [baseline] (208.127 ms) : 0, 208127
GlobalTracer [candidate] (208.073 ms) : 0, 208073
AppSec [baseline] (32.856 ms) : 0, 32856
AppSec [candidate] (32.687 ms) : 0, 32687
Debugger [baseline] (65.801 ms) : 0, 65801
Debugger [candidate] (65.899 ms) : 0, 65899
Remote Config [baseline] (574.958 µs) : 0, 575
Remote Config [candidate] (572.23 µs) : 0, 572
Telemetry [baseline] (8.051 ms) : 0, 8051
Telemetry [candidate] (8.055 ms) : 0, 8055
Flare Poller [baseline] (3.501 ms) : 0, 3501
Flare Poller [candidate] (3.556 ms) : 0, 3556
Profiling [baseline] (94.696 ms) : 0, 94696
Profiling [candidate] (94.26 ms) : 0, 94260
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (1.247 ms) : 1235, 1260
. : milestone, 1247,
iast (3.373 ms) : 3325, 3421
. : milestone, 3373,
iast_FULL (6.08 ms) : 6017, 6142
. : milestone, 6080,
iast_GLOBAL (3.634 ms) : 3575, 3692
. : milestone, 3634,
profiling (2.165 ms) : 2144, 2186
. : milestone, 2165,
tracing (1.888 ms) : 1872, 1903
. : milestone, 1888,
section candidate
no_agent (1.266 ms) : 1254, 1278
. : milestone, 1266,
iast (3.399 ms) : 3345, 3453
. : milestone, 3399,
iast_FULL (6.184 ms) : 6120, 6248
. : milestone, 6184,
iast_GLOBAL (3.661 ms) : 3600, 3723
. : milestone, 3661,
profiling (2.202 ms) : 2180, 2225
. : milestone, 2202,
tracing (1.907 ms) : 1891, 1923
. : milestone, 1907,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (17.305 ms) : 17132, 17477
. : milestone, 17305,
appsec (19.576 ms) : 19376, 19775
. : milestone, 19576,
code_origins (18.167 ms) : 17988, 18345
. : milestone, 18167,
iast (18.178 ms) : 17996, 18361
. : milestone, 18178,
profiling (18.171 ms) : 17989, 18353
. : milestone, 18171,
tracing (18.226 ms) : 18047, 18406
. : milestone, 18226,
section candidate
no_agent (19.148 ms) : 18950, 19347
. : milestone, 19148,
appsec (18.665 ms) : 18475, 18855
. : milestone, 18665,
code_origins (18.041 ms) : 17863, 18219
. : milestone, 18041,
iast (18.302 ms) : 18118, 18485
. : milestone, 18302,
profiling (18.383 ms) : 18198, 18569
. : milestone, 18383,
tracing (17.901 ms) : 17725, 18077
. : milestone, 17901,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
appsec (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
iast (18.342 s) : 18342000, 18342000
. : milestone, 18342000,
iast_GLOBAL (17.986 s) : 17986000, 17986000
. : milestone, 17986000,
profiling (15.422 s) : 15422000, 15422000
. : milestone, 15422000,
tracing (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
section candidate
no_agent (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
appsec (14.772 s) : 14772000, 14772000
. : milestone, 14772000,
iast (18.704 s) : 18704000, 18704000
. : milestone, 18704000,
iast_GLOBAL (17.634 s) : 17634000, 17634000
. : milestone, 17634000,
profiling (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
tracing (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~13c321a07b, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (1.5 ms) : 1489, 1512
. : milestone, 1500,
appsec (2.563 ms) : 2507, 2618
. : milestone, 2563,
iast (2.302 ms) : 2232, 2372
. : milestone, 2302,
iast_GLOBAL (2.341 ms) : 2270, 2412
. : milestone, 2341,
profiling (2.55 ms) : 2386, 2713
. : milestone, 2550,
tracing (2.1 ms) : 2046, 2155
. : milestone, 2100,
section candidate
no_agent (1.499 ms) : 1487, 1510
. : milestone, 1499,
appsec (3.835 ms) : 3612, 4058
. : milestone, 3835,
iast (2.3 ms) : 2230, 2371
. : milestone, 2300,
iast_GLOBAL (2.338 ms) : 2267, 2409
. : milestone, 2338,
profiling (2.531 ms) : 2366, 2696
. : milestone, 2531,
tracing (2.094 ms) : 2040, 2148
. : milestone, 2094,
|
dougqh
approved these changes
Apr 29, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds missing thread-related metadata (thread name and id) to spans in the V1 trace mapper.
Motivation
While dogfooding the
v1protocol in a real application and inspecting traces in the Datadog Web UI, I noticed that the initial implementation in #10801 does not include thread metadata in spans.Additional Notes
The
v0.4protocol already serializes these attributes, so the V1 implementation should align with that behavior.