Expand AGENTS.md with performance, API, and build guidance for AI agents#10642
Draft
Expand AGENTS.md with performance, API, and build guidance for AI agents#10642
Conversation
Add 5 new sections (performance guidelines, forbidden APIs, thread safety, dependency/build rules, API boundaries) and expand 3 existing sections (build commands, code conventions, bootstrap constraints) to reduce AI agent review cycles by capturing established norms from commit history and codebase analysis.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066321
Total [baseline] (10.948 s) : 0, 10947910
Agent [candidate] (1.063 s) : 0, 1063442
Total [candidate] (10.887 s) : 0, 10886996
section appsec
Agent [baseline] (1.262 s) : 0, 1261913
Total [baseline] (11.111 s) : 0, 11111318
Agent [candidate] (1.238 s) : 0, 1237966
Total [candidate] (11.041 s) : 0, 11040650
section iast
Agent [baseline] (1.248 s) : 0, 1247795
Total [baseline] (11.224 s) : 0, 11223809
Agent [candidate] (1.233 s) : 0, 1233085
Total [candidate] (11.21 s) : 0, 11209544
section profiling
Agent [baseline] (1.193 s) : 0, 1193222
Total [baseline] (10.957 s) : 0, 10957256
Agent [candidate] (1.193 s) : 0, 1193364
Total [candidate] (10.896 s) : 0, 10895562
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (628.284 ms) : 0, 628284
BytebuddyAgent [candidate] (626.948 ms) : 0, 626948
AgentMeter [baseline] (29.056 ms) : 0, 29056
AgentMeter [candidate] (29.085 ms) : 0, 29085
GlobalTracer [baseline] (257.6 ms) : 0, 257600
GlobalTracer [candidate] (257.669 ms) : 0, 257669
AppSec [baseline] (32.827 ms) : 0, 32827
AppSec [candidate] (32.904 ms) : 0, 32904
Debugger [baseline] (65.431 ms) : 0, 65431
Debugger [candidate] (62.8 ms) : 0, 62800
Remote Config [baseline] (608.122 µs) : 0, 608
Remote Config [candidate] (636.25 µs) : 0, 636
Telemetry [baseline] (9.941 ms) : 0, 9941
Telemetry [candidate] (11.553 ms) : 0, 11553
Flare Poller [baseline] (5.267 ms) : 0, 5267
Flare Poller [candidate] (4.559 ms) : 0, 4559
section appsec
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (670.423 ms) : 0, 670423
BytebuddyAgent [candidate] (656.944 ms) : 0, 656944
AgentMeter [baseline] (12.216 ms) : 0, 12216
AgentMeter [candidate] (11.943 ms) : 0, 11943
GlobalTracer [baseline] (263.344 ms) : 0, 263344
GlobalTracer [candidate] (258.029 ms) : 0, 258029
AppSec [baseline] (170.345 ms) : 0, 170345
AppSec [candidate] (167.978 ms) : 0, 167978
Debugger [baseline] (67.768 ms) : 0, 67768
Debugger [candidate] (66.632 ms) : 0, 66632
Remote Config [baseline] (656.334 µs) : 0, 656
Remote Config [candidate] (649.982 µs) : 0, 650
Telemetry [baseline] (9.546 ms) : 0, 9546
Telemetry [candidate] (9.39 ms) : 0, 9390
Flare Poller [baseline] (3.753 ms) : 0, 3753
Flare Poller [candidate] (3.715 ms) : 0, 3715
IAST [baseline] (26.184 ms) : 0, 26184
IAST [candidate] (25.431 ms) : 0, 25431
section iast
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (806.428 ms) : 0, 806428
BytebuddyAgent [candidate] (795.835 ms) : 0, 795835
AgentMeter [baseline] (11.852 ms) : 0, 11852
AgentMeter [candidate] (11.292 ms) : 0, 11292
GlobalTracer [baseline] (250.014 ms) : 0, 250014
GlobalTracer [candidate] (248.423 ms) : 0, 248423
AppSec [baseline] (32.829 ms) : 0, 32829
AppSec [candidate] (32.383 ms) : 0, 32383
Debugger [baseline] (68.941 ms) : 0, 68941
Debugger [candidate] (68.3 ms) : 0, 68300
Remote Config [baseline] (553.891 µs) : 0, 554
Remote Config [candidate] (539.812 µs) : 0, 540
Telemetry [baseline] (8.677 ms) : 0, 8677
Telemetry [candidate] (8.637 ms) : 0, 8637
Flare Poller [baseline] (3.485 ms) : 0, 3485
Flare Poller [candidate] (3.461 ms) : 0, 3461
IAST [baseline] (27.432 ms) : 0, 27432
IAST [candidate] (26.941 ms) : 0, 26941
section profiling
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (683.277 ms) : 0, 683277
BytebuddyAgent [candidate] (683.527 ms) : 0, 683527
AgentMeter [baseline] (8.586 ms) : 0, 8586
AgentMeter [candidate] (8.567 ms) : 0, 8567
GlobalTracer [baseline] (216.143 ms) : 0, 216143
GlobalTracer [candidate] (216.569 ms) : 0, 216569
AppSec [baseline] (32.568 ms) : 0, 32568
AppSec [candidate] (32.537 ms) : 0, 32537
Debugger [baseline] (67.457 ms) : 0, 67457
Debugger [candidate] (67.189 ms) : 0, 67189
Remote Config [baseline] (624.411 µs) : 0, 624
Remote Config [candidate] (624.452 µs) : 0, 624
Telemetry [baseline] (8.877 ms) : 0, 8877
Telemetry [candidate] (8.947 ms) : 0, 8947
Flare Poller [baseline] (3.814 ms) : 0, 3814
Flare Poller [candidate] (3.776 ms) : 0, 3776
ProfilingAgent [baseline] (99.858 ms) : 0, 99858
ProfilingAgent [candidate] (99.632 ms) : 0, 99632
Profiling [baseline] (100.433 ms) : 0, 100433
Profiling [candidate] (100.199 ms) : 0, 100199
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065995
Total [baseline] (8.816 s) : 0, 8816318
Agent [candidate] (1.07 s) : 0, 1069642
Total [candidate] (8.751 s) : 0, 8751450
section iast
Agent [baseline] (1.234 s) : 0, 1234459
Total [baseline] (9.409 s) : 0, 9409044
Agent [candidate] (1.237 s) : 0, 1237385
Total [candidate] (9.446 s) : 0, 9446221
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (628.87 ms) : 0, 628870
BytebuddyAgent [candidate] (631.412 ms) : 0, 631412
AgentMeter [baseline] (29.083 ms) : 0, 29083
AgentMeter [candidate] (29.243 ms) : 0, 29243
GlobalTracer [baseline] (258.037 ms) : 0, 258037
GlobalTracer [candidate] (259.067 ms) : 0, 259067
AppSec [baseline] (33.095 ms) : 0, 33095
AppSec [candidate] (33.367 ms) : 0, 33367
Debugger [baseline] (62.911 ms) : 0, 62911
Debugger [candidate] (63.222 ms) : 0, 63222
Remote Config [baseline] (610.548 µs) : 0, 611
Remote Config [candidate] (627.225 µs) : 0, 627
Telemetry [baseline] (9.997 ms) : 0, 9997
Telemetry [candidate] (9.903 ms) : 0, 9903
Flare Poller [baseline] (5.997 ms) : 0, 5997
Flare Poller [candidate] (5.297 ms) : 0, 5297
section iast
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (798.864 ms) : 0, 798864
BytebuddyAgent [candidate] (799.707 ms) : 0, 799707
AgentMeter [baseline] (11.334 ms) : 0, 11334
AgentMeter [candidate] (11.547 ms) : 0, 11547
GlobalTracer [baseline] (247.57 ms) : 0, 247570
GlobalTracer [candidate] (248.949 ms) : 0, 248949
AppSec [baseline] (33.222 ms) : 0, 33222
AppSec [candidate] (33.389 ms) : 0, 33389
Debugger [baseline] (66.62 ms) : 0, 66620
Debugger [candidate] (66.461 ms) : 0, 66461
Remote Config [baseline] (535.024 µs) : 0, 535
Remote Config [candidate] (539.201 µs) : 0, 539
Telemetry [baseline] (8.59 ms) : 0, 8590
Telemetry [candidate] (8.773 ms) : 0, 8773
Flare Poller [baseline] (3.43 ms) : 0, 3430
Flare Poller [candidate] (3.427 ms) : 0, 3427
IAST [baseline] (26.892 ms) : 0, 26892
IAST [candidate] (27.155 ms) : 0, 27155
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section baseline
no_agent (1.213 ms) : 1201, 1226
. : milestone, 1213,
iast (3.236 ms) : 3189, 3283
. : milestone, 3236,
iast_FULL (5.768 ms) : 5711, 5825
. : milestone, 5768,
iast_GLOBAL (3.629 ms) : 3574, 3683
. : milestone, 3629,
profiling (1.94 ms) : 1924, 1956
. : milestone, 1940,
tracing (1.781 ms) : 1766, 1796
. : milestone, 1781,
section candidate
no_agent (1.194 ms) : 1182, 1206
. : milestone, 1194,
iast (3.249 ms) : 3203, 3294
. : milestone, 3249,
iast_FULL (5.803 ms) : 5745, 5861
. : milestone, 5803,
iast_GLOBAL (3.501 ms) : 3440, 3562
. : milestone, 3501,
profiling (1.996 ms) : 1979, 2013
. : milestone, 1996,
tracing (1.795 ms) : 1780, 1810
. : milestone, 1795,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section baseline
no_agent (17.854 ms) : 17672, 18036
. : milestone, 17854,
appsec (18.759 ms) : 18572, 18946
. : milestone, 18759,
code_origins (17.75 ms) : 17573, 17928
. : milestone, 17750,
iast (17.828 ms) : 17649, 18007
. : milestone, 17828,
profiling (18.584 ms) : 18395, 18774
. : milestone, 18584,
tracing (17.48 ms) : 17306, 17654
. : milestone, 17480,
section candidate
no_agent (17.781 ms) : 17603, 17959
. : milestone, 17781,
appsec (18.365 ms) : 18181, 18548
. : milestone, 18365,
code_origins (17.824 ms) : 17645, 18003
. : milestone, 17824,
iast (17.578 ms) : 17405, 17750
. : milestone, 17578,
profiling (18.537 ms) : 18354, 18720
. : milestone, 18537,
tracing (19.149 ms) : 18957, 19342
. : milestone, 19149,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.79 ms) : 3564, 4016
. : milestone, 3790,
iast (2.253 ms) : 2184, 2323
. : milestone, 2253,
iast_GLOBAL (2.303 ms) : 2233, 2372
. : milestone, 2303,
profiling (2.096 ms) : 2040, 2152
. : milestone, 2096,
tracing (2.06 ms) : 2007, 2114
. : milestone, 2060,
section candidate
no_agent (1.472 ms) : 1460, 1484
. : milestone, 1472,
appsec (2.563 ms) : 2506, 2621
. : milestone, 2563,
iast (2.254 ms) : 2186, 2323
. : milestone, 2254,
iast_GLOBAL (2.299 ms) : 2229, 2368
. : milestone, 2299,
profiling (2.109 ms) : 2053, 2166
. : milestone, 2109,
tracing (2.062 ms) : 2008, 2115
. : milestone, 2062,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~d5f1dfc89c, baseline=1.60.0-SNAPSHOT~064a8aac98
dateFormat X
axisFormat %s
section baseline
no_agent (15.091 s) : 15091000, 15091000
. : milestone, 15091000,
appsec (14.707 s) : 14707000, 14707000
. : milestone, 14707000,
iast (18.192 s) : 18192000, 18192000
. : milestone, 18192000,
iast_GLOBAL (17.631 s) : 17631000, 17631000
. : milestone, 17631000,
profiling (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
tracing (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
section candidate
no_agent (14.739 s) : 14739000, 14739000
. : milestone, 14739000,
appsec (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
iast (18.533 s) : 18533000, 18533000
. : milestone, 18533000,
iast_GLOBAL (17.962 s) : 17962000, 17962000
. : milestone, 17962000,
profiling (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
tracing (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 5 new sections (performance guidelines, forbidden APIs, thread safety, dependency/build rules, API boundaries) and expand 3 existing sections (build commands, code conventions, bootstrap constraints) to reduce AI agent review cycles by capturing established norms from commit history and codebase analysis.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.