attempt to add a flag to disable backtrace#120
Open
nyaaaaaaatalie wants to merge 1 commit intoDVMProject:masterfrom
Open
attempt to add a flag to disable backtrace#120nyaaaaaaatalie wants to merge 1 commit intoDVMProject:masterfrom
nyaaaaaaatalie wants to merge 1 commit intoDVMProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since OpenWRT is special and uses musl instead of gnulib, the newly introduced backtrace/Backward lib will fail to compile as execinfo.h is missing. The easiest way to fix this for right now is to add a flag to disable backtraces.
By setting
ENABLE_BACKWARD=0cmake will set theBACKWARD_SYSTEM_UNKNOWNmacro which essentially turns Backward into a no-op.Component(s)
Which part(s) of the project does this affect?
Type of change
Related issues
n/a
Closes #
Refs #
Build & test notes
Built and tested on Linux and OpenWRT
Include:
Logs / output (if applicable)
Paste relevant output demonstrating the fix or behavior change.
Checklist
Notes for maintainers
Anything reviewers should be aware of? n/a