Repository navigation
fix(deploy): harden production web startup - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//# sourceMappingURL=chart.umd.min.js.mapreference from the vendored Chart.js build socollectstatic(WhiteNoiseCompressedManifestStaticFilesStorage) no longer fails post-processing on a missing.mapfile.webcontainer startup fail-fast:set -ebeforemigrate/collectstatic, andexec gunicorn ...so Gunicorn replaces the shell instead of running under a shell that swallowed an earlier failure.--no-control-socket) to stop thePermission denied: '/home/appuser'error, without creating a home directory or changing the image's user.Test plan
docker compose -f docker/docker-compose-traefik.yml -f docker/docker-compose.cd.yml configrenders cleanly with fictitious values (same set as the "Validate production Compose stack" CI job)web.commandconfirmed to containset -e/migrate/collectstatic/exec gunicorn ... --no-control-socketuv run python manage.py collectstatic --noinputexits 0, nochart.umd.min.js.mapreference, no post-processing failurejust lint(ruff check, ty check, codespell, bandit) passesuv run pre-commit run(staged files) passesjust test— 558 passed