Skip to content

feat: count superseded reviews toward the cap - #457

Open
huang47 wants to merge 1 commit into
codex/cursor-three-reviewfrom
codex/cursor-count-superseded
Open

huang47 wants to merge 1 commit into
codex/cursor-three-reviewfrom
codex/cursor-count-superseded

Conversation

@huang47

@huang47 huang47 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

A review does not stop costing effort simply because a new commit arrived before the result was acted on. Callers can choose to count that delivered review toward their limit instead of treating it as a free extra round.

Motivation

A review limit can serve as a budget for delivered reviews. Excluding a delivered review after the head moves makes that budget less predictable. Callers that need the existing behavior keep it by default.

Provenance

  • Authored by: interactive session
  • Verified: Cursor review suite passed 1,754 tests, including a regression that distinguishes the default behavior from the opt-in. Workflow documentation and pin suite passed 551 tests (43 skipped). Workflow pin, agent-instruction and repository-literal checks passed. Local actionlint reported the same 98 diagnostics as the base, with no new diagnostics.
  • Deviations: The option does not count undelivered panels, prevent a human reset, serialize concurrent runs, or cover other review systems. It is not a lifetime execution cap. Current-head CI passed; CodeRabbit was skipped. A live caller run has not been verified.

Reviewer context

Summary

  • Let callers include delivered reviews whose decisions observed a moved head in the existing review counter.
  • Keep the previous default and document both the option and its boundaries.

Test plan

  • Exercise the opt-in with a delivered review followed by a moved-head decision.
  • Verify callers that omit it retain the existing counter behavior.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 26f44829-4ab6-4f38-bdcb-59041d24d473

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants