Skip to content

fix: keep unverified human approvals incomplete - #454

Open
huang47 wants to merge 1 commit into
codex/readiness-reviewer-permissionsfrom
codex/readiness-human-identity
Open

huang47 wants to merge 1 commit into
codex/readiness-reviewer-permissionsfrom
codex/readiness-human-identity

Conversation

@huang47

@huang47 huang47 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

GitHub can label an automated account as a User. A write permission and an approval do not establish that the reviewer is a person, so the shadow report keeps human approval evidence incomplete until identity has an independent proof.

Summary

Input Before After
Current User approval with write access, human identity unverified Could count as human approval Approval evidence remains incomplete
Current unresolved finding or change request Blocked Blocked

The collector still reads permissions and preserves known blockers. It does not supply an identity-verification source, enable a pilot, write reviews or change rules. Revert this change to restore prior shadow behavior, accepting its identity ambiguity.

Stack order: 9/9. Parent: #453.

Verification

  • New regression fails on the parent and passes here; 65 readiness tests pass.
  • Workflow pin, agent instruction and public-repository literal checks pass.
  • Current-head CI passed; CodeRabbit skipped. The shadow run retained a WAITING report under a synthetic policy. No human approvals were present, so it did not exercise a live permission lookup.
  • Human identity, code-owner policy, complete findings and tested revision remain unverified.

Provenance

Authored in an interactive implementation session for a code review contract. No private repository details are included.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 94f94219-9ce1-4f13-9a8d-99a15c8012e6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@huang47
huang47 marked this pull request as ready for review November 21, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants