-
Notifications
You must be signed in to change notification settings - Fork 29
Dom merge conflict edit #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Poonam-raj
wants to merge
3
commits into
main
Choose a base branch
from
dom-merge-conflict-edit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Buttons and Counter | ||
|
|
||
| This app currently features a button that increments a counter. | ||
|
|
||
| ## Task for Person A | ||
|
|
||
| Create and switch to a new branch named `split-app-components`: | ||
|
|
||
| ``` | ||
| git switch -c split-app-components | ||
| ``` | ||
|
|
||
| ### Task | ||
|
|
||
| Split the `header`, `main` into separate components from `app.js`. | ||
|
|
||
| - Separate the components into new functions that live in their own files. | ||
| - Make sure to use those functions in `app.js` so the end result remains the same, and tests still run. | ||
| - Remember - tests are your friend, run them before, during and after you've wrote some code. Use them to guide you. | ||
|
|
||
| ### Tests | ||
|
|
||
| There are three tests that are _not_ skipped (lines 18 - 36 ihn `app.test.js`), use these tests to check your changes still let the app function as expected. | ||
|
|
||
| ### Result | ||
|
|
||
| - You should end up with an `app.js` file, a `header.js` file, and a `main.js` file in your `src` directory. | ||
| - All tests should pass. | ||
|
|
||
| ## Task for Person B | ||
|
|
||
| Create and switch to a new branch named `add-decrement-button`: | ||
|
|
||
| ``` | ||
| git switch -c add-decrement-button | ||
| ``` | ||
|
|
||
| ### Task | ||
|
|
||
| Implement a decrement button. | ||
|
|
||
| - Read the skipped tests (lines 38-53 in `app.test.js`) before you start. You will use these tests to guide you. | ||
| - Write your code in `app.js` | ||
| - Update the description of the app in the `header` element. | ||
|
|
||
| ### Tests | ||
|
|
||
| Tests (lines 38-53 in `app.test.js`) are pre-written but skipped, un-skip them and run the tests before, during and after you write your code. | ||
|
|
||
| ### Result | ||
|
|
||
| Your `app.js` file will now contain a button that decrements the counter and all the tests will run and pass. | ||
File renamed without changes.
File renamed without changes.
23 changes: 0 additions & 23 deletions
23
dom-merge-conflict/tasks/buttons-and-counter/instructions.md
This file was deleted.
Oops, something went wrong.
32 changes: 0 additions & 32 deletions
32
dom-merge-conflict/tasks/conditional-rendering/instructions.md
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
dom-merge-conflict/tasks/conditional-rendering/src/profilePreview.js
This file was deleted.
Oops, something went wrong.
95 changes: 0 additions & 95 deletions
95
dom-merge-conflict/tasks/conditional-rendering/test/profilePreview.test.js
This file was deleted.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
dom-merge-conflict/tasks/optimistic-rendering/instructions.md
This file was deleted.
Oops, something went wrong.
30 changes: 0 additions & 30 deletions
30
dom-merge-conflict/tasks/optimistic-rendering/src/voter.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.