London | 26-ITP-Sep | Abakar Souleyman | Sprint 3 | implement-and-rewrite-tests by abmhts · Pull Request #1660 · CodeYourFuture/Module-Structuring-and-Testing-Data

abmhts · 2026-10-08T20:09:35Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1059

Changelist

Completed the implementation and rewrote the tests using node:test and jest.

hackertainment

Thank you for your coursework. Please keep it up.

hackertainment · 2026-10-09T20:49:25Z

+test("Classifies for angles outside the valid range.", () => {
+  const invalid = getAngleType(361);
+  assert.equal(invalid, "Invalid angle");
+});


There should be two boundary case for angles outside the valid range. Can you think of them? Please add them into this test suite. Thank you.

Added the lower boundary (exactly 0°) and upper boundary (exactly 360°). Thank you.

hackertainment · 2026-10-09T20:50:17Z

Good coverage of test cases. Well done!

hackertainment · 2026-10-09T20:52:35Z

I don't think this program runs correctly for positives, negatives, and zeros. Can you fix it? Thank you.

Added Math.abs to return absolute value of the number. Thank you.

hackertainment · 2026-10-09T20:53:04Z

The test cases should also include negatives and zeros. Please add them back. Thank you.

Included negatives and zeros. Thank you.

hackertainment · 2026-10-09T20:54:48Z

+test(`should return false when numerator is (-)`, () => {
+  expect(isProperFraction(-1, 0)).toEqual(true);
+});


The description does not match the expected output. Which one is correct?

Corrected. Thanks

hackertainment · 2026-10-09T20:55:25Z

There should be more test cases covering different combination of positive and negative values. Please add them back. Thank you.

Added more test cases. Thank you

hackertainment · 2026-10-09T21:02:14Z

I am not quite sure about the correctness of this program. Please fix the following issues:

formatting (e.g. indentation, brackets, etc)

making if and else if cleaner to read, covering all possible combinations (instead of hardcode specific values)

try to store card.slice(0, -1) into a variable and reuse it (instead of slice it multiple times)

If you find it difficult to approach this problem, try to book a mentored coding session and work this out with a volunteer together.

I cleaned up the indentation and corrected the misplaced brackets in the number check.

Cleaner if / else if: I removed the hardcoded cards and now check the rank against groups (ace, face cards, number cards), so every valid combination works.

Reused slice: I stored card.slice(0, -1) in a rank variable (and card.slice(-1) in suit) so each is sliced once and reused.

Thank you.

Good fix, and it looks much better now. Hope you would appreciate the importance of writing clean code :-)

hackertainment · 2026-10-11T17:44:02Z

Congratulation, you have completed this PR successfully.

abmhts added 6 commits October 6, 2026 17:26

angle type node:test

394a8dc

proper fraction node:test

0bc3787

get card value node:test

42a359a

get angle type - jest

9cfaca3

proper fraction - jest

28b8908

get value - jest

0deca03

abmhts added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 8, 2026

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 9, 2026

hackertainment reviewed Oct 9, 2026

View reviewed changes

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 9, 2026

hackertainment mentioned this pull request Oct 9, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

abmhts added 6 commits October 10, 2026 14:32

Added the lower boundary (exactly 0°) and upper boundary (exactly 360°).

1ea9237

added Math.abs

0f3d125

Included negatives and zeros.

c2b0ef2

update - proper fraction test.jest

677e167

update2

7c3ddb9

Refactor - to handle all valid cards and reject invalid ones

4ae7675

abmhts added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 11, 2026

hackertainment added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2026

Conversation

abmhts commented Oct 8, 2026

Task code

Changelist

Uh oh!

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Oct 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hackertainment Oct 11, 2026 •

edited

Loading