Repository navigation
North West | 26-ITP-Sep | Brian Yorachi | Sprint 1 | Exhaustively test and fix formatAs12HourClock - #1655
Open
BrianY315 wants to merge 4 commits into
Open
North West | 26-ITP-Sep | Brian Yorachi | Sprint 1 | Exhaustively test and fix formatAs12HourClock#1655BrianY315 wants to merge 4 commits into
BrianY315 wants to merge 4 commits into
Conversation
Cover valid time boundaries and preserve minutes across conversion.
Pad single-digit afternoon hours and align edge-case test formatting.
Exercise all 1,440 valid HH:mm values against the 12-hour output.
BrianY315
added
📅 Sprint 1
JaypeeLan
added
Review in progress
JaypeeLan
reviewed
Oct 7, 2026
There was a problem hiding this comment.
This works... but what if the value of time passed is not what you expect? e.g a Boolean or an array. A base case should guard that.
Author
There was a problem hiding this comment.
Thank you for the review. The guard issue has been fixed.
JaypeeLan
added
Reviewed
JaypeeLan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1197.
Changelist
Identified tests for important edge cases that use the formatAs12HourClock function and fixed the code so that it works correctly.