London | 26-ITP-Sep | Bartosz Kawiak | Sprint 2| Practice-TDD by bartoszkawiak · Pull Request #1650 · CodeYourFuture/Module-Structuring-and-Testing-Data

bartoszkawiak · 2026-10-05T18:50:30Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1060

Changelist

Completed today’s TDD exercises using Jest. Implemented the required functions and wrote tests to cover the expected behaviour and edge cases.

Poonam-raj · 2026-10-07T11:06:52Z

+  if (strNum.endsWith("1")) {
+    return strNum + "st";
+  } else if (strNum.endsWith("2")) {
+    return strNum + "nd";
+  } else if (strNum.endsWith("3")) {
+    return strNum + "rd";
+  } else {
+    return strNum + "th";
+  }


Slight refactor possible here: if we are returning a value from each if statement do we need the else if or is a if statement enough?

Here I'm thinking about cleaning up the code to do the bare minimum, avoiding overengineering when it doesn't actually change the behaviour in the code.

Removed the unnecessary else statement since "th" is already addressed.

I get a failing test for your 'th' tests now. I believe you've just deleted a core functionality.

Please re-look at this.

My original comment was actually about the else if blocks on lines 11 - 17, not the 'th' behaviour

I misunderstood your original feedback and removed the default return statement. I've corrected this now.

Poonam-raj

I have a few areas I need you to iron out and the repeat-str function needs to be redesigned completely. Please look at my comments and address those changes - thank you

Poonam-raj · 2026-10-12T14:59:17Z

This function fails the screenshotted error test - take another look at the code

I've added validation for negative counts so the function throws an error as expected, rather than returning an empty string.

Poonam-raj

thank you for your work on improving this code!

Few tests not passing at the moment, take another look at my remaining comments. Thanks :D

bartoszkawiak added 3 commits October 5, 2026 18:18

count.js + tests completed

e75c3f6

repeat-str.js + tests completed

ba2b1c2

get-oridinal-number.js + tests completed

2dd8319

bartoszkawiak added 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 5, 2026

Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2026