London | 26-ITP-May | Mandip Sanger| Sprint 3| Practice Tdd - #1597
Open
mandipsanger wants to merge 15 commits into
Open
London | 26-ITP-May | Mandip Sanger| Sprint 3| Practice Tdd#1597mandipsanger wants to merge 15 commits into
mandipsanger wants to merge 15 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
mandipsanger
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandipsanger
changed the title
This comment has been minimized.
This comment has been minimized.
mandipsanger
changed the title
This comment has been minimized.
This comment has been minimized.
mandipsanger
added
🏕 Priority Mandatory
hackertainment
added
Review in progress
Comment on lines
+43
to
+50
| test("should return 0 when the character does not occur in the string", () => { | ||
| const str = "hello"; | ||
| const char = "z"; | ||
|
|
||
| const count = countChar(str, char); | ||
|
|
||
| expect(count).toEqual(0); | ||
| }); |
There was a problem hiding this comment.
There should be more test cases for multiple occurrences because the example just tested the case of character in the whole string.
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| }); | ||
| test('should append "nd" when the number ends with 2', () => { | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); |
There was a problem hiding this comment.
By referencing to the given example, please add more unique test cases within this test set.
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| }); | ||
| test('should append "rd" when the number ends with 3', () => { | ||
| expect(getOrdinalNumber(23)).toEqual("23rd"); |
There was a problem hiding this comment.
By referencing to the given example, please add more unique test cases within this test set.
Comment on lines
+23
to
+33
| // Case 2: Numbers ending with 11 | ||
| test('should append "th" when the number ends with 11', () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| }); | ||
| // Then the function should return a string by appending "st" to the number. | ||
| test('should append "th" when the number ends with 12', () => { | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| }); | ||
| test('should append "th" when the number is 13', () => { | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| }); |
There was a problem hiding this comment.
It's good that you tested the special cases of 11, 12, and 13. It would be nice if larger values (like 511th or 413th) are tested as well.
There was a problem hiding this comment.
How about empty string (with the same set of counts 3, 1, 0, -1)?
hackertainment
left a comment
hackertainment
left a comment
There was a problem hiding this comment.
Generally good and in the right direction. Just the test cases can cover more unique scenarios. Keep it up :-)
hackertainment
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
PR sprint 3 tdd