Skip to content

London | May - 26 | Liridona Shehu | Sprint 2 | Coursework #1358

Open
shehu-dona wants to merge 13 commits into
CodeYourFuture:mainfrom
shehu-dona:coursework/sprint-2
Open

London | May - 26 | Liridona Shehu | Sprint 2 | Coursework #1358
shehu-dona wants to merge 13 commits into
CodeYourFuture:mainfrom
shehu-dona:coursework/sprint-2

Conversation

@shehu-dona

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [ x] I have tested my changes
  • [ x] My changes follow the style guide

Changelist

PR with JS exercises for Sprint 2 - Structuring and Testing Data Module

@shehu-dona shehu-dona added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 17, 2026
@shehu-dona shehu-dona changed the title London | May - 26| Liridona Shehu | Sprint 2 | Structuring and testing data London | May - 26 | Liridona Shehu | Sprint 2 | Structuring and testing data Jun 17, 2026
@shehu-dona shehu-dona changed the title London | May - 26 | Liridona Shehu | Sprint 2 | Structuring and testing data London | May - 26 | Liridona Shehu | Sprint 2 | Coursework Jun 17, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this task, only one for you to take another look at.

Comment thread Sprint-2/3-mandatory-implement/1-bmi.js Outdated
// It should return their Body Mass Index to 1 decimal place

function calculateBMI(weight, height) {
let = bodyMassIndex = weight / (height * height);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try running this function? Does it work?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello LonMcGregor,

I have read the comments and updated the code. But surprisingly the function was working even before. Apparently my vs code it considered let as a variable not as a keyword for variable declaration.

Screenshot from 2026-06-22 18-11-29

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026
@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants