West Midlands | 26-May-ITP | Alina Sofragiu | Sprint 1 | Coursework#1342
Open
sofragiualina wants to merge 1 commit into
Open
West Midlands | 26-May-ITP | Alina Sofragiu | Sprint 1 | Coursework#1342sofragiualina wants to merge 1 commit into
sofragiualina wants to merge 1 commit into
Conversation
sofragiualina
added
📅 Sprint 1
LonMcGregor
reviewed
Jun 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this task, lots of good explanations. There's one task where I left a comment for you to review
| //It removes the extra seconds first, then divides by 60 to get complete minutes | ||
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
|
|
||
| //The movie length formatted as hours:minutes:seconds a better name could be movieTime |
There was a problem hiding this comment.
Is it clear enough what the difference is between a "length" and a "time"?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed JavaScript exercises with explanations and comments added throughout the code to improve understanding.