London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Dead Code #1254
Open
miriamjorna wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Dead Code #1254miriamjorna wants to merge 3 commits intoCodeYourFuture:mainfrom
miriamjorna wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
miriamjorna
added
📅 Sprint 3
SlideGauge
reviewed
Mar 15, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Overall dead code removed correctly, I got a couple of minor notes about the style, please address them and that will be ok
|
|
||
| let testName = "Jerry"; | ||
| const greeting = "hello"; | ||
| const testName = "Aman"; |
Sprint-3/3-dead-code/exercise-1.js
Outdated
|
|
||
| function sayHello(greeting, name) { | ||
| const greetingStr = greeting + ", " + name + "!"; | ||
| const sayHello = (greeting, name) => { |
There was a problem hiding this comment.
the task was to remove dead code, whilst usage of arrow function style here is clever, it goes beyond the task, could you revert it please?
Sprint-3/3-dead-code/exercise-1.js
Outdated
| const greetingMessage = sayHello(greeting, testName); | ||
|
|
||
| console.log(greetingMessage); // 'hello, Aman!' | ||
| console.log(greetingMessage); // 'hello, Aman!' No newline at end of file |
| @@ -2,13 +2,8 @@ | |||
| // The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. | |||
SlideGauge
removed
the
Needs Review
miriamjorna
added
the
Needs Review
Author
|
Both changes implemented as instructed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR has already been reviewed by @Edu-Vin, but needed to be resubmitted to get rid of some persistent deleted Sprint-2 directories as the branching-off wasn't as clean as I had imagined.
NB I also have a directory ready for you with the 1+3 emails and the rejection reflection, plus proof of demos given and attended, and peer pair working.
Thanks for your time!