Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | dead code#1253
Open
marthak1 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | dead code#1253marthak1 wants to merge 2 commits intoCodeYourFuture:mainfrom
marthak1 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
marthak1
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
marthak1
added
the
Needs Review
marthak1
changed the title
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
marthak1
added
📅 Sprint 3
ykamal
reviewed
Mar 12, 2026
Sprint-3/3-dead-code/exercise-2.js
Outdated
|
|
||
| const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; | ||
| const capitalisedPets = pets.map((pet) => pet.toUpperCase()); | ||
| const petsStartingWithH = pets.filter((pet) => pet[0] === "h"); |
There was a problem hiding this comment.
Would this work if the character were uppercase?
Author
There was a problem hiding this comment.
Thanks for the feedback. Given this current code the answer is no, because the filter is only looking for lowercase character "h". I have now updated the filter for case sensitivity
ykamal
added
Reviewed
Refactor petsStartingWithH to handle case sensitivity.
marthak1
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Removed dead code from exercise