Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 3 | Stretch Coursework#1250
Open
Richiealx wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 3 | Stretch Coursework#1250Richiealx wants to merge 2 commits intoCodeYourFuture:mainfrom
Richiealx wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Richiealx
added
the
Needs Review
4 tasks
ykamal
reviewed
Mar 12, 2026
| return password.length < 5 ? false : true | ||
| } | ||
| // Password must be at least 5 characters long. | ||
| if (password.length < 5) { |
There was a problem hiding this comment.
Could password just not be provided at all?
Author
There was a problem hiding this comment.
Hi @ykamal,
Good point, thank you.
I updated the function to handle the case where a password is not provided.
Previously the function accessed password.length, which would throw an error if the value was undefined.
I added an input validation check at the start of the function to ensure the password exists and is a string. If it is missing or not a string, the function now safely returns false.
I also added test cases to cover these scenarios.
ykamal
added
Reviewed
Richiealx
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the Sprint 3 stretch tasks.
Password Validator
password-validator.jspassword-validator.test.jsCredit Card Validator
card-validator.jscard-validator.test.jsTesting
All tests were run using:
All tests passed successfully.