Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | coursework/sprint-3-implement-and-rewrite#1240
Open
marthak1 wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | coursework/sprint-3-implement-and-rewrite#1240marthak1 wants to merge 7 commits intoCodeYourFuture:mainfrom
marthak1 wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
marthak1
added
📅 Sprint 3
Edu-Vin
added
Review in progress
Edu-Vin
reviewed
Mar 10, 2026
There was a problem hiding this comment.
I think you should check the definition of a proper fraction again and see if your test case for negative numbers is correct expecially -3/8. I will advise you to use Match.abs()
Edu-Vin
reviewed
Mar 10, 2026
| test(`Should throw an error`, () => { | ||
| expect(() => { | ||
| getCardValue("♠9"); | ||
| }).toThrow(); |
There was a problem hiding this comment.
This is good. To take it further, add a test to see if the returned error message is what you are expecting.
Edu-Vin
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist