Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 3 | Practice tdd #1202
Open
Dan2Clouted wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 3 | Practice tdd #1202Dan2Clouted wants to merge 5 commits intoCodeYourFuture:mainfrom
Dan2Clouted wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
Dan2Clouted
added
the
Needs Review
cjyuan
reviewed
Mar 12, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is good.
You missed updating get-oridinal-number.test.js.
cjyuan
added
Reviewed
Dan2Clouted
added
the
Needs Review
Author
|
Ah yes, I have updated it now. |
cjyuan
reviewed
Mar 12, 2026
Author
|
I have updated the test description to make the category of numbers clearer. |
cjyuan
reviewed
Mar 13, 2026
| }); | ||
|
|
||
| test("should append 'th' for all other numbers", () => { | ||
| test("should append 'th' for numbers that do not end in 1, 2, or 3, and are not 11, 12, or 13", () => { |
Contributor
There was a problem hiding this comment.
Could also directly express the trailing digits in this group.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed Practice tdd