-
-
Notifications
You must be signed in to change notification settings - Fork 337
Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 3 | Practice-tdd #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,18 @@ | ||
| // our function; | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| if (!stringOfCharacters || !findCharacter) { | ||
| return 0; | ||
| } | ||
| let numberOfChar = 0; | ||
| for (let wantedChar of stringOfCharacters) { | ||
| if (wantedChar === findCharacter) { | ||
| numberOfChar++; | ||
| } | ||
| if (numberOfChar === 0) { | ||
| return `0 ${findCharacter} found.` | ||
| } | ||
| } | ||
| return numberOfChar; | ||
| } | ||
|
|
||
| module.exports = countChar; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,19 @@ | ||
| // lets develop our function. | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
|
|
||
| const lastDigit = num % 10; // ==> 111 % 10 = 11.1 last digit is 1. | ||
| const lastTwoDigits = num % 100; // 111 % 100 = 111 last two digits 11. | ||
|
|
||
| if (lastTwoDigits >= 11 && lastTwoDigits <= 13){ | ||
| return `${num}th`;// ==> finds the last two digits to equal (11,12,13) | ||
| } | ||
| if(lastDigit == 1){ | ||
| return `${num}st`; | ||
| }else if (lastDigit == 2){ | ||
| return `${num}nd`; | ||
| }else if (lastDigit == 3){ | ||
| return `${num}rd`; | ||
| } else return `${num}th`; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,27 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" | |
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(131)).toEqual("131st"); | ||
| }); | ||
| test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| expect(getOrdinalNumber(222)).toEqual("222nd"); | ||
| }); | ||
| test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(33)).toEqual("33rd"); | ||
| expect(getOrdinalNumber(333)).toEqual("333rd"); | ||
| }); | ||
| test("should append 'th' for numbers ending with 4 and more than 4", () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(44)).toEqual("44th"); | ||
| expect(getOrdinalNumber(444)).toEqual("444th"); | ||
| expect(getOrdinalNumber(5)).toEqual("5th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| expect(getOrdinalNumber(100)).toEqual("100th"); | ||
| expect(getOrdinalNumber(105)).toEqual("105th"); | ||
| }); | ||
| test("should append 'th' for numbers ending with 11, 12 and 13", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (count < 0) | ||
| throw new Error("Negative counts are not valid"); | ||
| if (count === 0) return ""; | ||
| else return str.repeat(count); | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,23 +10,27 @@ const repeatStr = require("./repeat-str"); | |
| // Then it should return a string that contains the original `str` repeated `count` times. | ||
|
|
||
| test("should repeat the string count times", () => { | ||
| const str = "hello"; | ||
| const count = 3; | ||
| const repeatedStr = repeatStr(str, count); | ||
| expect(repeatedStr).toEqual("hellohellohello"); | ||
| expect(repeatStr("Love", 3)).toEqual("LoveLoveLove"); | ||
| }); | ||
|
|
||
| // Case: handle count of 1: | ||
| // Given a target string `str` and a `count` equal to 1, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return the original `str` without repetition. | ||
|
|
||
| test("should print the original string", () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "print" may suggest the function should output the string. |
||
| expect(repeatStr("Love", 1)).toEqual("Love"); | ||
| }); | ||
| // Case: Handle count of 0: | ||
| // Given a target string `str` and a `count` equal to 0, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return an empty string. | ||
|
|
||
| test("should return an empty string", () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could probably make this description more informative by including the |
||
| expect(repeatStr("Love", 0)).toEqual(""); | ||
| }); | ||
| // Case: Handle negative count: | ||
| // Given a target string `str` and a negative integer `count`, | ||
| // When the repeatStr function is called with these inputs, | ||
| // Then it should throw an error, as negative counts are not valid. | ||
| test("should throw and error when count is a negative number", () => { | ||
| expect(()=> repeatStr("Love", -3)).toThrow("Negative counts are not valid"); | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is expected to return an integer number. Returning a string would make the function difficult to use because the caller would need to check the data type of the return value.