Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 3 | Practice TDD by Pretty548 · Pull Request #1133 · CodeYourFuture/Module-Structuring-and-Testing-Data

Pretty548 · 2026-03-02T16:43:26Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

In this PR I implemented the required functions using the TDD approach.

Wrote tests first before implementing the functions
Made the tests pass by writing the correct logic
Refactored the code to improve readability and structure
Ensured all tests pass successfully using Jest

Questions

I would appreciate feedback on:

Whether my TDD workflow is correct
Code structure and readability
Test quality and naming

… including edge cases

…om> reverted to main

cjyuan

Functions look good.

Tests could use some improvement.

Also, can you remove any unused code and unnecessary comments from the files to keep them cleaner? They make the code less readable.

Sprint-3/2-practice-tdd/count.test.js

Sprint-3/2-practice-tdd/get-ordinal-number.js

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

Sprint-3/2-practice-tdd/repeat-str.test.js

Project-CLI-Treasure-Hunt

…entation

cjyuan

Without the "Needs Review" label, I am not sure if this PR ready to be re-reviewed.

Please note that now your branch has three files not belonging to the TDD exercise.

cjyuan · 2026-03-12T12:34:47Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

-test("should append 'th' for numbers ending with 11, 12, or 13", () => {
+test("should append 'th' for special cases 11, 12, or 13", () => {


I think the previous description is better.

Yes definitely, i changed it.

cjyuan · 2026-03-13T15:39:02Z

You deleted files in other subfolders under Sprint-3 in your latest commit. Deleted files are considered "changed files", and that's why the validation bot complained.

You can copy the original files from CYF repo to replace the files you deleted, or you can use "git revert" to undo the commit which you deleted all those files. After you restore those files, make a commit.

Or you can create a new PR, include a comment that it is a continuation from this PR, and tag me in the new PR.

…/Pretty548/Module-Structuring-and-Testing-Data into coursework/sprint-3-practice-tdd

cjyuan · 2026-03-15T10:59:59Z

Changes look good.

And well done in fixing the branch.

Pretty Taruvinga added 8 commits February 25, 2026 11:26

feat: implement countChar function

0b65a57

test: add unit tests for countChar function

18ef756

Implement getOrdinalNumber with correct suffix logic

9d908d9

Add category-based tests for ordinal number suffixes (st, nd, rd, th)…

715c649

… including edge cases

test: add tests for repeatStr

2af6c11

Co-authored-by: Isaac Abodunrin <bytesandroses@users.noreply.github.com>

4098eb1

refactor: simplify repeatStr using String.prototype.repeat

77bc6be

Revert to main branch

b7a3a6f

This comment has been minimized.

Sign in to view

Pretty548 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 2, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026

This comment has been minimized.

Sign in to view

Pretty Taruvinga added 2 commits March 2, 2026 18:52

Co-authored-by: Isaac Abodunrin <bytesandroses@users.noreply.github.c…

92422ef

…om> reverted to main

revert to main

444a5ec

Pretty548 marked this pull request as draft March 2, 2026 17:09

Pretty548 marked this pull request as ready for review March 2, 2026 17:09

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026

Pretty Taruvinga added 2 commits March 2, 2026 19:12

revert to main

5ae7a46

revert to main

d7f002f

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026

Pretty548 mentioned this pull request Mar 5, 2026

Cape Town | Structuring and testing data | Pretty Taruvinga Pretty548/My-Coursework-Planner#72

Open

cjyuan reviewed Mar 10, 2026

View reviewed changes

cjyuan reviewed Mar 12, 2026

View reviewed changes

Sprint-3/2-practice-tdd/repeat-str.test.js Show resolved Hide resolved

Project-CLI-Treasure-Hunt Outdated Show resolved Hide resolved

Pretty Taruvinga added 2 commits March 12, 2026 07:18

fix: remove duplicate getAngleType function and ensure correct implem…

7217ad7

…entation

test: improve getOrdinalNumber test descriptions and coverage

607161c

cjyuan reviewed Mar 12, 2026

View reviewed changes

Pretty Taruvinga added 3 commits March 13, 2026 13:44

deleted un related file

65182a5

reverted to previous description

ab1f15e

fixed the function

f980882

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 13, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 13, 2026

Remove unrelated sprint folders from PR

77df336

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 13, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 13, 2026

Pretty Taruvinga and others added 2 commits March 15, 2026 12:00

restored deleted files

ff3d1d3

Merge branch 'main' into coursework/sprint-3-practice-tdd

2dd8a26

Pretty548 marked this pull request as draft March 15, 2026 10:03

Pretty548 marked this pull request as ready for review March 15, 2026 10:03

Pretty548 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 15, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 15, 2026

This comment has been minimized.

Sign in to view

Pretty Taruvinga added 2 commits March 15, 2026 12:12

restored the deleted file

32f9cc1

Merge branch 'coursework/sprint-3-practice-tdd' of https://github.com…

15df447

…/Pretty548/Module-Structuring-and-Testing-Data into coursework/sprint-3-practice-tdd

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 15, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026

		test("should append 'th' for numbers ending with 11, 12, or 13", () => {
		test("should append 'th' for special cases 11, 12, or 13", () => {

Uh oh!

Conversation

Pretty548 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Pretty548 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjyuan commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjyuan commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pretty548 commented Mar 2, 2026 •

edited

Loading

cjyuan commented Mar 13, 2026 •

edited

Loading