London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 2 | Coursework by djebsoft · Pull Request #1123 · CodeYourFuture/Module-Structuring-and-Testing-Data

djebsoft · 2026-03-01T22:53:43Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

complete sprint 2 mandatory tasks

Questions

Corrected variable declaration issue and updated function to return the capitalized string.

…ge function Removed duplicate declaration of decimalNumber and updated the function to correctly convert a decimal to a percentage.

Corrected the square function to accept a parameter and return its square.

Refactor multiply function to return result and log output.

Corrected the sum function to return the sum of two numbers.

Corrected the getLastDigit function to accept a parameter and return the last digit of the given number.

Corrected the function getLastDigit to properly accept a parameter.

Added explanations and answers to questions regarding the pad function in time-format.js.

Implemented the toPounds function to convert pence to pounds.

Added a function to convert a string to upper snake case.

cjyuan · 2026-03-11T03:19:04Z

Sprint-2/2-mandatory-debug/0.js

+function multiply(a, b) {
+  return console.log(
+    `The result of multiplying ` + a + ` and ` + b + ` is ` + a * b
+  );
+}


If there is a need to output the string in a fixed format from different "places" in the program, it would make sense to implement a function do so.

However, what is the purpose of returning the return value of console.log()? What value do you expect console.log() to return?

we just actually need the function to pass the output to the next line of code after its destroyed
so we need the function to return what its statement evaluate to

Not sure what you meant by "destroyed".

cjyuan · 2026-03-11T03:22:10Z

Sprint-2/3-mandatory-implement/1-bmi.js

 function calculateBMI(weight, height) {
-    // return the BMI of someone based off their weight and height
-}
+  return (BMI = (weight / (height * height)).toFixed(1)); // return the BMI of someone based off their weight and height


What is BMI? Why not just return the value of the expression (weight / (height * height)).toFixed(1)?

What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

console.log(123); // Output 123 console.log("123"); // Output 123 // Treated differently in the program let sum1 = 123 + 100; // Evaluate to 223 -- a number let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.

fixed the statement of the value returned
converted the string to a number

Sprint-2/3-mandatory-implement/2-cases.js

…n statement

… number

djebsoft · 2026-03-12T01:57:08Z

thank you for reviewing my work
I followed your comments and fixed the bugs

cjyuan · 2026-03-12T02:43:40Z

Sprint-2/3-mandatory-implement/1-bmi.js

 function calculateBMI(weight, height) {
-    // return the BMI of someone based off their weight and height
-}
+  return Number(weight / (height * height)).toFixed(1); // return the BMI of someone based off their weight and height


How can you be sure that the function is returning a number and not a string?

by adding the number() to the expression that contains strings
but after your comment I checked it using typeof and it turns out it's string
then I included the whole expression in the number() by adding parentheses, then it worked
but prettier didn't allow me to save the change so I made it in my github remote repository

cjyuan · 2026-03-12T02:46:59Z

Sprint-2/3-mandatory-implement/2-cases.js

 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+function upperSnakeCase(wordsSet) {
+  let wsSnakeCase = wordsSet.replaceAll(" ", "_");
+  let wsupperSnakeCase = wsSnakeCase.toUpperCase();


What do you think about this version:wsUpperSnakeCase? (No change needed)

I think it could be shortened and embeded in the previous line

cjyuan · 2026-03-12T04:37:17Z

Changes are good. Well done.

djebsoft added 11 commits February 28, 2026 00:25

declaraing the variable 'result' in capitalise function

eac1a1b

Corrected variable declaration issue and updated function to return the capitalized string.

Fix duplicate variable declaration and assigning in convertToPercenta…

0a7da43

…ge function Removed duplicate declaration of decimalNumber and updated the function to correctly convert a decimal to a percentage.

Fix square function parameter

45b6a43

Corrected the square function to accept a parameter and return its square.

Fix multiply function to return and log result

b594c90

Refactor multiply function to return result and log output.

Fix sum function to return correct value

7fbd07f

Corrected the sum function to return the sum of two numbers.

Fix getLastDigit function to return correct last digit

54e11ce

Corrected the getLastDigit function to accept a parameter and return the last digit of the given number.

Fixing typo

97bdb37

Corrected the function getLastDigit to properly accept a parameter.

Implement BMI calculation in calculateBMI function

9dfa312

Update comments with answers in time-format.js

5fb3b93

Added explanations and answers to questions regarding the pad function in time-format.js.

turn the to-pounds program into a reusable block of code

b745976

Implemented the toPounds function to convert pence to pounds.

Implement upperSnakeCase function

6dcd3ad

Added a function to convert a string to upper snake case.

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 1, 2026

djebsoft added 13 commits March 7, 2026 19:06

formatting using prettier

98c6c44

formatting using prettier

49c0e77

formatting using prettier

f46495a

formatting using prettier

3a4cd9c

formatting using prettier

0187c34

formatting using prettier

d824908

formatting using prettier

e3e2a6e

formatting using prettier

d979e47

formatting using prettier

074eddb

formatting using prettier

614b5fc

formatting using prettier

4e87db6

formatting using prettier

ecbbbef

formatting using prettier

69ae220

cjyuan reviewed Mar 11, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 11, 2026

djebsoft added 2 commits March 12, 2026 01:07

deleted the console.log statement from the function and added a retur…

0f84719

…n statement

fixed the statement of the value returned & converted the output to a…

3adc57d

… number

fixed the function to return the coverted value

1393ad5

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026

cjyuan reviewed Mar 12, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026

Fix return statement in calculateBMI function

132b50e

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026

djebsoft mentioned this pull request Mar 14, 2026

ITP_Jan_2026 | Structuring and testing data| Boualem Larbi Djebbour djebsoft/My-Coursework-Planner#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 2 | Coursework#1123

London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 2 | Coursework#1123
djebsoft wants to merge 28 commits intoCodeYourFuture:mainfrom
djebsoft:coursework/sprint-2

djebsoft commented Mar 1, 2026

Uh oh!

cjyuan Mar 11, 2026

Uh oh!

djebsoft Mar 12, 2026

Uh oh!

cjyuan Mar 12, 2026

Uh oh!

cjyuan Mar 11, 2026

Uh oh!

djebsoft Mar 12, 2026

Uh oh!

Uh oh!

djebsoft commented Mar 12, 2026

Uh oh!

cjyuan Mar 12, 2026

Uh oh!

djebsoft Mar 12, 2026 •

edited

Loading

Uh oh!

cjyuan Mar 12, 2026

Uh oh!

djebsoft Mar 12, 2026 •

edited

Loading

Uh oh!

cjyuan commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

djebsoft commented Mar 1, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

djebsoft Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

djebsoft Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

djebsoft commented Mar 12, 2026

Uh oh!

cjyuan Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

djebsoft Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

djebsoft Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

djebsoft Mar 12, 2026 •

edited

Loading

djebsoft Mar 12, 2026 •

edited

Loading