Glasgow | Jan-26-ITP | Fattouma Ouannassi | Sprint 3 | coursework/sprint-3-practice-tdd#1094
Conversation
FAprogrammerO
added
the
Needs Review
FAprogrammerO
force-pushed
the
coursework/sprint-3practice-tdd
branch
from
b53bdab to
eac7d73
Compare
kyle-tightest
left a comment
kyle-tightest
left a comment
There was a problem hiding this comment.
get-ordinal-number and repeat-str.js look good! its just count.js that has some issues
Sprint-3/2-practice-tdd/count.js
Outdated
| // function countChar(stringOfCharacters, findCharacter) { | ||
| // let count = 0; | ||
| // for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| // if (stringOfCharacters[i] === findCharacter) { | ||
| // count++; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
The ITP assignment does need countChar method to be implemented so that the tests, which call countChar will pass
Sprint-3/2-practice-tdd/count.js
Outdated
| let numbers=[1,2,3,4,5,6,1,2,3,4,5,6] | ||
| let idxArray=[]; | ||
| numbers.find((el,ix,numbers)=>{ | ||
| if (el===3){ | ||
|
|
||
| idxArray.push(ix);} | ||
| }) | ||
| console.log(idxArray); |
There was a problem hiding this comment.
this piece of code does not seem to be related to the assignment.
please let me know if i can help you understand the problem better
or perhaps this was an accident?
There was a problem hiding this comment.
You're absolutely right the extra code with the numbers array was unrelated to the assignment and was left in accidentally during my testing. I've now uncommented and finalized the correct countChar implementation, removed all unrelated code snippets and verified that the function passes the expected test cases.
There was a problem hiding this comment.
ah okay, yes that makes sense. Just remember to always do a final check before pushing up
There was a problem hiding this comment.
Thank you so much for your helpful feedback I really appreciate the time and effort you took to review my submission. 🙏
I've noted your reminder about doing a final check before pushing, and I'll make sure to keep that in mind for future submissions.
Just to confirm: is there anything else you'd like me to adjust or improve in the code? If everything looks good on your end, would you mind updating the status label to Complete when you get a chance?
Thanks again for your support!
There was a problem hiding this comment.
hi @FAprogrammerO thanks, only a pleasure!
no sorry i meant to change it to complete.
done that now
kyle-tightest
added
Reviewed
FAprogrammerO
added
Needs Review
kyle-tightest
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
This project (sprint 3) focuses on learning how to use JavaScript methods and npm test the code.
Questions
N/A