Skip to content

Birmingham | 26-ITP-May | Lesya Lyaisyan | Sprint 2 | Wireframe#1360

Open
LesyaLyan wants to merge 4 commits into
CodeYourFuture:mainfrom
LesyaLyan:feature/wireframe
Open

Birmingham | 26-ITP-May | Lesya Lyaisyan | Sprint 2 | Wireframe#1360
LesyaLyan wants to merge 4 commits into
CodeYourFuture:mainfrom
LesyaLyan:feature/wireframe

Conversation

@LesyaLyan
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Wrote a new webpage explaining the purposes of a README file, Wireframe and Git
Branches, Using the provided wireframe and resources.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 0627ab4
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a175fc10b84da00081d27ea
😎 Deploy Preview https://deploy-preview-1360--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@LesyaLyan LesyaLyan added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 27, 2026
Copy link
Copy Markdown

@Stephanieewelu Stephanieewelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well-written, beginner-friendly HTML page about README files, Wireframes, and Git Branches.

Strengths
• Correct semantic HTML ( 

 ,   ,  
 ,   ,   )
• Proper heading hierarchy (one  

 , then  

 s)
• All images have  alt  text
•  loading="lazy"  and  fetchpriority="high"  used correctly
• Meta description and  lang="en"  present

Issues to Fix
• External links are missing  target="_blank" rel="noopener noreferrer" 
• Inconsistent image sizes — first image is  600×300 , others are  200×250 
• Wireframe Wikipedia URL should be  /wiki/Website_wireframe , not  /wiki/Wireframe 
• Footer could include a copyright symbol/year for polish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants