Glasgow | 26-ITP-May | Chan Yat Long | Sprint 2 | Wireframe

[Motorcycle-lab]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Page made according to specification. However, I was not able to remove the trailing slash on HTML tags ( /> ) as I couldn't configure prettier to stop adding them.

Questions

Before I forgot how to open a new branch, I have saved all my previous commit in the main branch, How can I move these commits to the newest branch that I created.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	e4b2713
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0b35eb4d3546000827bb0e
😎 Deploy Preview	https://deploy-preview-1239--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 99 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 73 (🔴 down 13 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Your main is 5 commits ahead of CYF's main, meaning you have "polluted" your main branch and those changes can propagate to future branches based on main.

One way to delete the latest 5 commits is to run these commands on terminal in VSCode:

git checkout main
git reset --hard HEAD~5
git push --force

Note: Please backup all your files (in all branches) before you executed these command. You may lose your files if you are not careful.

[cjyuan]

Can you improve the Lighthouse score from 98 to 100?

[cjyuan]

Page looks good. Can you address these few issues to better match the wireframe?

• Can you center the content on the footer to match the wireframe, and ensure the footer content won't overlap with the page content?

• In the wireframe image, all three article appear to have the same format. In your implementation, the title of the articles do not look quite the same.

---

On separate note, nice job in reverting the change in your main branch. Currently your main is 4 commits behind the upstream branch (CYF's main). You can click the "Sync fork" button to keep your branches up to date.

[cjyuan]

What is this image for? It is not used on the page.

[cjyuan]

Code in this file is not yet properly formatted.

[cjyuan]

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • You may find the suggestions in this PR Guide useful.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.