London | 26-ITP-January | Laura C | Sprint 2 | Data Groups#979
Open
lauracs24 wants to merge 13 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Laura C | Sprint 2 | Data Groups#979lauracs24 wants to merge 13 commits intoCodeYourFuture:mainfrom
lauracs24 wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
lauracs24
added
the
Needs Review
JaypeeLan
added
the
Review in progress
JaypeeLan
reviewed
Mar 11, 2026
| module.exports = tally; | ||
| const counts = {}; | ||
|
|
||
| for (const item of items) { |
There was a problem hiding this comment.
I think you should also check if the array has values.
Author
There was a problem hiding this comment.
I added a check for the empty array case and pushed the update. Thanks!
JaypeeLan
added
Reviewed
lauracs24
added
the
Needs Review
JaypeeLan
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Debug
address.jsby accessing object propertyauthor.jsby iterating through object keysrecipe.jsto correctly display the nice ingredientsImplement
containsfunctionlookupfunctiontallyfunctionquerystringimplementation to handle values containing "="Interpret
invertto swap keys and valuesAll tests pass successfully using
npm test.