Glasgow | 26-ITP-Jan| Martin McLean |Sprint 1| coursework#978
Open
mjm-git185 wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
Glasgow | 26-ITP-Jan| Martin McLean |Sprint 1| coursework#978mjm-git185 wants to merge 6 commits intoCodeYourFuture:mainfrom
mjm-git185 wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
mjm-git185
changed the title
This comment has been minimized.
This comment has been minimized.
mjm-git185
changed the title
mjm-git185
added
the
Needs Review
JaypeeLan
added
Review in progress
JaypeeLan
reviewed
Mar 12, 2026
There was a problem hiding this comment.
This works, but there can be some improvements.
Check that elements is an array before calling .filter(), and do an early return if it is empty.
Sorting the entire array is unnecessary if you only need the maximum value.
Consider using Number.isFinite() to ensure only valid numbers are included, so no need for typeof element === "number"
JaypeeLan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework