Skip to content

London | 26-ITP-January | Laura C | Sprint 1 | Data Groups#976

Open
lauracs24 wants to merge 10 commits intoCodeYourFuture:mainfrom
lauracs24:sprint-1
Open

London | 26-ITP-January | Laura C | Sprint 1 | Data Groups#976
lauracs24 wants to merge 10 commits intoCodeYourFuture:mainfrom
lauracs24:sprint-1

Conversation

@lauracs24
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Completed Fix section (calculateMedian)
  • Implemented max, sum, and dedupe using TDD
  • Refactored includes to use a for...of loop
  • Ensured all tests pass (fix, implement, refactor)
  • Made small, incremental commits throughout the work

@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
@lauracs24 lauracs24 moved this to Awaiting Approval🚀 in Coursework Planner Mar 3, 2026
@JaypeeLan JaypeeLan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number.isFinite() already ensures it is a number, so you don't need to check the type.
Also, the filter is not needed, you can do the check in the for of loop, so you don't have 2 loops.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've refactored the implementation to remove the filter and perform the Number.isFinite() check directly inside the for of loop.

@JaypeeLan JaypeeLan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 11, 2026
@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 11, 2026
@JaypeeLan JaypeeLan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants