London | 26-ITP-Jan | Raihan | Sprint 2 | Book Library#386
Open
RaihanSharif wants to merge 13 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Raihan | Sprint 2 | Book Library#386RaihanSharif wants to merge 13 commits intoCodeYourFuture:mainfrom
RaihanSharif wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
Duplicate: title and author both the same as an existing book. Not case sensitive.
RaihanSharif
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Fixed functional isses:
Usability changes:
Changed "read" to "completed" in the HTML for clarity
Changed object property from "checked" to "completed" for clarity.
Removed dead code
Questions
The render function should be refactored into several functions, as it does several things at the same time. I didn't do this, let me know if this is required.