Repository navigation
NW| 26-Jul-SDC | Ahmad Hmedan | Sprint 2 | Improve code with caches - #235
Open
AhmadHmedann wants to merge 5 commits into
Open
AhmadHmedann wants to merge 5 commits into
AhmadHmedann wants to merge 5 commits into
Conversation
AhmadHmedann
added
the
Needs Review
cjyuan
reviewed
Oct 10, 2026
Comment on lines
+20
to
+37
| @@ -26,7 +32,11 @@ def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | |||
| if total_from_coins == total: | |||
| ways += 1 | |||
| else: | |||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | |||
| intermediate = ways_to_make_change_helper( | |||
| total - total_from_coins, coins=coins[coin_index + 1 :], cache=cache | |||
| ) | |||
There was a problem hiding this comment.
Array and tuple creations are relatively costly operations.
From lines 27 and 36, we know coins can only be one of the following 9 arrays:
[200, 100, 50, 20, 10, 5, 2, 1]
[100, 50, 20, 10, 5, 2, 1]
[50, 20, 10, 5, 2, 1]
...
[1]
[]
We could further improve the performance if we can
- avoid repeatedly creating the same sub-arrays at line 36 (e.g. use another cache), and
- create key as (total, a_unique_integer_identifying_the_subarray) instead of as (total, tuple of coins)
- There are only a small number of different subarrays. We can easily assign each subarray a unique integer.
Author
There was a problem hiding this comment.
Thank you for the feedback. I hope this addresses your points. I've updated the code to reuse the original list instead of creating new lists and tuples in each recursive call.
cjyuan
added
Reviewed
AhmadHmedann
added
Needs Review
|
Changes look good. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1182
Changelist