Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 1 | Analyse and Refactor Functions

Sprint-1/JavaScript/calculateSumAndProduct/calculateSumAndProduct.js

@@ -9,21 +9,18 @@
  *   "product": 30 // 2 * 3 * 5
  * }
  *
- * Time Complexity:
- * Space Complexity:
- * Optimal Time Complexity:
+ * Time Complexity: before fix O(2N), after double loop removed - O(N)
+ * Space Complexity: 0(N) - depends on numbers.length
+ * Optimal Time Complexity: O(N)
  *
  * @param {Array<number>} numbers - Numbers to process
  * @returns {Object} Object containing running total and product
  */
 export function calculateSumAndProduct(numbers) {
   let sum = 0;
-  for (const num of numbers) {
-    sum += num;
-  }
-
   let product = 1;
   for (const num of numbers) {
+    sum += num;
     product *= num;
   }
 

Sprint-1/JavaScript/findCommonItems/findCommonItems.js

@@ -1,14 +1,17 @@
 /**
  * Finds common items between two arrays.
  *
- * Time Complexity:
- * Space Complexity:
- * Optimal Time Complexity:
+ * Time Complexity: worst O(N1 * N2)
+ * Space Complexity: worst O(N1 + N2)
+ * Optimal Time Complexity: worst become: O(N1 + N2)
  *
  * @param {Array} firstArray - First array to compare
  * @param {Array} secondArray - Second array to compare
  * @returns {Array} Array containing unique common items
  */
-export const findCommonItems = (firstArray, secondArray) => [
-  ...new Set(firstArray.filter((item) => secondArray.includes(item))),
-];
+export const findCommonItems = (firstArray, secondArray) => {
+  const firstSet = new Set(firstArray);
+  const secondSet = new Set(secondArray);
+  secondArray = [...secondSet].filter((element) => firstSet.has(element))
+  return secondArray;
+};

Sprint-1/JavaScript/hasPairWithSum/hasPairWithSum.js

@@ -1,20 +1,20 @@
 /**
  * Find if there is a pair of numbers that sum to a given target value.
  *
- * Time Complexity:
- * Space Complexity:
- * Optimal Time Complexity:
+ * Time Complexity: worst O(N!) - factorial
+ * Space Complexity: O(numbers.length)
+ * Optimal Time Complexity: worth become O(N)
  *
  * @param {Array<number>} numbers - Array of numbers to search through
  * @param {number} target - Target sum to find
  * @returns {boolean} True if pair exists, false otherwise
  */
+
 export function hasPairWithSum(numbers, target) {
+
   for (let i = 0; i < numbers.length; i++) {
-    for (let j = i + 1; j < numbers.length; j++) {
-      if (numbers[i] + numbers[j] === target) {
-        return true;
-      }
+    if (numbers.includes(target - numbers[i])) {
+      return true;
     }
   }
   return false;

Sprint-1/JavaScript/removeDuplicates/removeDuplicates.mjs

@@ -1,36 +1,20 @@
 /**
  * Remove duplicate values from a sequence, preserving the order of the first occurrence of each value.
  *
- * Time Complexity:
- * Space Complexity:
- * Optimal Time Complexity:
+ * Time Complexity: O(N*N) quadratic
+ * Space Complexity: O(N)
+ * Optimal Time Complexity: become O(N)
  *
  * @param {Array} inputSequence - Sequence to remove duplicates from
  * @returns {Array} New sequence with duplicates removed
  */
 export function removeDuplicates(inputSequence) {
   const uniqueItems = [];
-
-  for (
-    let currentIndex = 0;
-    currentIndex < inputSequence.length;
-    currentIndex++
-  ) {
-    let isDuplicate = false;
-    for (
-      let compareIndex = 0;
-      compareIndex < uniqueItems.length;
-      compareIndex++
-    ) {
-      if (inputSequence[currentIndex] === uniqueItems[compareIndex]) {
-        isDuplicate = true;
-        break;
-      }
-    }
-    if (!isDuplicate) {
-      uniqueItems.push(inputSequence[currentIndex]);
+  inputSequence.forEach((element) => {
+    if (!uniqueItems.includes(element)) {
+      uniqueItems.push(element);
     }
-  }
+  });
 
   return uniqueItems;
 }

Sprint-1/Python/calculate_sum_and_product/calculate_sum_and_product.py

@@ -12,20 +12,19 @@ def calculate_sum_and_product(input_numbers: List[int]) -> Dict[str, int]:
         "sum": 10, // 2 + 3 + 5
         "product": 30 // 2 * 3 * 5
     }
-    Time Complexity:
-    Space Complexity:
-    Optimal time complexity:
+    Time Complexity: O(N*2)
+    Space Complexity: O(N)
+    Optimal time complexity: O(N)
     """
     # Edge case: empty list
     if not input_numbers:
         return {"sum": 0, "product": 1}
 
     sum = 0
-    for current_number in input_numbers:
-        sum += current_number
-
     product = 1
     for current_number in input_numbers:
+        sum += current_number
         product *= current_number
+
 
     return {"sum": sum, "product": product}

Sprint-1/Python/find_common_items/find_common_items.py

@@ -9,13 +9,10 @@ def find_common_items(
     """
     Find common items between two arrays.
 
-    Time Complexity:
-    Space Complexity:
-    Optimal time complexity:
+    Time Complexity: worst O(N1 * N2)
+    Space Complexity: worst O(N1 + N2)
+    Optimal time complexity: worst become: O(N1 + N2)
     """
-    common_items: List[ItemType] = []
-    for i in first_sequence:
-        for j in second_sequence:
-            if i == j and i not in common_items:
-                common_items.append(i)
-    return common_items
+    firstSet = set(first_sequence)
+    secondSet = set(first_sequence)
+    return list(firstSet.intersection(secondSet))

Sprint-1/Python/has_pair_with_sum/has_pair_with_sum.py

@@ -7,12 +7,12 @@ def has_pair_with_sum(numbers: List[Number], target_sum: Number) -> bool:
     """
     Find if there is a pair of numbers that sum to a target value.
 
-    Time Complexity:
-    Space Complexity:
-    Optimal time complexity:
+    Time Complexity: worst O(N!) - factorial
+    Space Complexity: O(numbers.length)
+    Optimal time complexity: worth become O(N)
     """
+
     for i in range(len(numbers)):
-        for j in range(i + 1, len(numbers)):
-            if numbers[i] + numbers[j] == target_sum:
-                return True
+        if (numbers[i] - target_sum) in numbers:
+            return True
     return False

Sprint-1/Python/remove_duplicates/remove_duplicates.py

@@ -7,19 +7,14 @@ def remove_duplicates(values: Sequence[ItemType]) -> List[ItemType]:
     """
     Remove duplicate values from a sequence, preserving the order of the first occurrence of each value.
 
-    Time complexity:
-    Space complexity:
-    Optimal time complexity:
+    Time complexity: O(N*N) quadratic
+    Space complexity: O(N)
+    Optimal time complexity: become O(N)
     """
-    unique_items = []
 
+    unique_items = []
     for value in values:
-        is_duplicate = False
-        for existing in unique_items:
-            if value == existing:
-                is_duplicate = True
-                break
-        if not is_duplicate:
+        if value not in unique_items:
             unique_items.append(value)
 
     return unique_items