London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 2 | Implement LRU cache

[aydaeslami]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Implemented LRU cache with O(1) get and set operations using a doubly linked list and dictionary.

[cjyuan]

To better adhere to the Single-Responsibility Principle (SRP) from SOLID design principles,
it's preferable to implement the "doubly linked list" and the "LRU Cache" as separate classes, with the linked list used inside LruCache to manage ordering.
In fact, you can import your LinkedList class from the other exercise, and then store each key-value pairs as a tuple.

Alternatively, you can use OrderedDict directly within LruCache to maintain order.

Could you update your code using one of these approaches?

[aydaeslami]

Thank you @cjyuan for the suggestion. I refactored the implementation to use OrderedDict , and it made the code much cleaner and easier to read.

I also appreciated the reminder about the Single Responsibility Principle (SRP).

Thanks for the helpful feedback!

[cjyuan]

Does OrderedDict have any built-in method to move its item to the end?

[aydaeslami]

Thanks for the suggestion. I've replaced the pop-and-reinsert approach with OrderedDict.move_to_end(), which makes the code cleaner and more readable.

I've also run the full test suite again, and all tests are passing.

Please let me know if there's anything else I should change or improve.

[cjyuan]

Why not implement this in lru_cache_test.py?