Skip to content

fix: secure index.js (CWE-494) #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: secure index.js (CWE-494) #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/utils/Updater/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,26 @@ const normalizeArch = (architecture) => {
}
};

/**
* Verify that a URL is HTTPS and hosted on a trusted CodeDead domain, to
* ensure update/download links from the remote API cannot be tampered with
* (e.g. via a compromised or MITM'd API response) to point to an untrusted host.
* @param url The URL to validate
* @returns {boolean} True if the URL is trusted, otherwise false
*/
const isTrustedUrl = (url) => {
try {
const parsed = new URL(url);
return (
parsed.protocol === 'https:' &&
(parsed.hostname === 'codedead.com' ||
parsed.hostname.endsWith('.codedead.com'))
);
} catch {
return false;
}
};

const Updater = (os, architecture, currentVersion) => {
/**
* Check whether version b is newer than version a
Expand Down Expand Up @@ -59,7 +79,12 @@ const Updater = (os, architecture, currentVersion) => {
);
const version = normalizeVersion(update.semver);

if (!platform || !version) {
if (
!platform ||
!version ||
!isTrustedUrl(platform.downloadUrl) ||
(platform.infoUrl && !isTrustedUrl(platform.infoUrl))
) {
return data;
}

Expand Down