Skip to content

Revert "fix: correct PDF viewer page count and input handling " #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YOGESH-08 merged 1 commit into from
Apr 21, 2026
Merged

Revert "fix: correct PDF viewer page count and input handling " #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions src/components/newPdfViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,24 +61,21 @@ const Controls = memo(function Controls({documentId, toggleFullscreen, isFullscr

const { provides: zoomProv, state: zoomState } = useZoom(documentId);
const { provides: scrollProv, state: scrollState } = useScroll(documentId);
const [pageNo, setPageNo] = useState("");
const [pageNo, setPageNo] = useState("1");

useEffect(() => {
if (!scrollProv) return;
const unsub = scrollProv.onPageChange(() => {
const current = scrollProv.getCurrentPage();
setPageNo(String(current));
});
const current = scrollProv.getCurrentPage();
setPageNo(String(current));
const unsub = scrollProv.onPageChange(() =>
setPageNo(String(scrollProv.getCurrentPage()))
);
return () => unsub();
}, [scrollProv]);

const pageChange = useCallback(
(e: React.KeyboardEvent<HTMLInputElement>) => {
if (e.key !== "Enter") return;
const page = parseInt(pageNo, 10);
if (!isNaN(page) && scrollState?.totalPages && page >= 1 && page <= scrollState.totalPages) {
if (!isNaN(page) && page >= 1 && page <= (scrollState?.totalPages ?? 1)) {
scrollProv?.scrollToPage({ pageNumber: page, behavior: "smooth" });
}
},
Expand All @@ -102,20 +99,13 @@ const Controls = memo(function Controls({documentId, toggleFullscreen, isFullscr
<div className={(!isFullscreen && !isMobile) ? "flex flex-col items-center gap-2" : "flex flex-row items-center gap-2"}>
<input
type="text"
value={totalPages ? pageNo : ""}
value={pageNo}
onChange={(e) => setPageNo(e.target.value)}
onKeyDown={pageChange}
onFocus={() => {
if (totalPages) setPageNo("");
}}
onBlur={() => {
if (!pageNo && scrollProv) {
setPageNo(String(scrollProv.getCurrentPage()));
}
}}
onFocus={() => setPageNo("")}
className="h-9 w-14 rounded border bg-[#e7e9ff] p-1 text-center text-sm [appearance:textfield] dark:bg-[#1f1f2a] [&::-webkit-inner-spin-button]:appearance-none [&::-webkit-outer-spin-button]:appearance-none"
/>
<span className="text-xs font-medium text-white">of {totalPages ?? "..."}</span>
<span className="text-xs font-medium text-white">of {totalPages ?? 1}</span>
</div>
)

Expand Down
Loading