Polish local install confirmations - #354
Open
sdairs wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a misleading/duplicate human-facing confirmation from the local ClickHouse install handler by relying on the version manager’s outcome-aware messages, while keeping the structured JSON install result unchanged for --json and coding-agent output.
Changes:
- Suppress the CLI-layer “Installed version …” human output for
local install, leaving human confirmations to the version manager and printing only in JSON mode. - Update the local-first install regression tests to run in human-output mode and assert that stdout contains no generic confirmation on no-op installs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/clickhousectl/src/local/mod.rs | Only emit InstallOutput via print_output when json is enabled, avoiding duplicate/misleading human confirmations. |
| crates/clickhousectl/tests/local_install_local_first_test.rs | Run install subprocesses in human-output mode and assert stdout is empty for no-op installs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sdairs
force-pushed
the
codex/issue-328-install-output-polish
branch
from
August 3, 2026 18:42
e09cda7 to
278c138
Compare
sdairs
force-pushed
the
codex/issue-328-install-output-polish
branch
from
August 3, 2026 19:34
278c138 to
a2efcd2
Compare
sdairs
marked this pull request as ready for review
August 3, 2026 20:04
sdairs
force-pushed
the
codex/issue-328-install-output-polish
branch
from
August 3, 2026 20:04
4561a55 to
efa1b41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--jsonand coding-agent consumersWhy
The version manager already distinguishes real installs from reused builds, but the CLI layer always appended
Installed version X. That produced duplicate confirmations after a real install and contradicted the no-op message when a matching version was already present.Impact
A no-op install now ends after the accurate “already installed” message and
--forcehint. A real install keeps the singleInstalled ClickHouse Xconfirmation emitted by the version manager. JSON output is unchanged.Stack
This PR is stacked on #352 and should be reviewed as the delta from
codex/issue-336-env-credential-precedence.Closes #328.
Validation
cargo fmt --all --checkcargo build -p clickhousectlcargo test -p clickhousectlcargo clippy -p clickhousectl --all-targets -- -D warnings