feat(new-icon): add new pop-in icon#1044
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b99b696 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kunalpanchal
force-pushed
the
kunal/add-pop-in-icon
branch
from
056b9c1 to
4aa065c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4aa065c. Configure here.
kunalpanchal
force-pushed
the
kunal/add-pop-in-icon
branch
from
4aa065c to
b8f8292
Compare
kunalpanchal
force-pushed
the
kunal/add-pop-in-icon
branch
from
b8f8292 to
1df0887
Compare
DreaminDani
approved these changes
Jun 2, 2026
kunalpanchal
force-pushed
the
kunal/add-pop-in-icon
branch
from
1df0887 to
b99b696
Compare
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-lkwbtsfbj-clickhouse.vercel.app Built from commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pop-inicon asset using the supplied SVG.pop-inis available through the icon library.Fixes #1005.
Note
Low Risk
Additive icon asset and registry entries only; no runtime or security-sensitive logic changes.
Overview
Adds a new
popinicon to the Click UI icon library, paired with the existingpopoutasset.A new
PopinSVG component is registered under the kebab-case namepopinin the light/dark icon maps,IconNametyping, and deprecated PascalCase alias (Popin). A minor changeset records the public API addition for@clickhouse/click-ui.Reviewed by Cursor Bugbot for commit b99b696. Bugbot is set up for automated code reviews on this repo. Configure here.