Skip to content

Implement Collapsible Groups#175

Open
Rsslone wants to merge 26 commits intoCleanroomMC:cleanroomfrom
Rsslone:cleanroom
Open

Implement Collapsible Groups#175
Rsslone wants to merge 26 commits intoCleanroomMC:cleanroomfrom
Rsslone:cleanroom

Conversation

@Rsslone
Copy link

@Rsslone Rsslone commented Mar 14, 2026

A compiled binary for testing can be found on my repo if you would like to test drive and break it.

Implements / Backports the idea of collapsible groups with built in filters and ability for user defined groups. Items adhere to current blacklists, blacklisted items will not appear.
image

New conditional function to HEI config menu button which toggles between expand all and collapse all.
image

4 new settings related to groups, 1 of which is a submenu for group management. All contain tooltip keys.
image

New submenu for group management, contains built in sets for Enchanted Books, Potions, Arrows, and Spawn Eggs.
image

New item selector for groups, groups are saved into a customCollapsibleGroups.json as individual items/gas/fluids, a current minor shortcoming is it does not handle individual NBT. Potential for replacing the old blacklist selection process, but was set aside for now. Currently the left panel supports click and drag, the right panel is single click only.
image

Special attention of areas I am less sure about, i.e help I need an adult.

Making enchanted books searchable, I know not the consequences of my actions.
1f66391
and
Cached baked models, this is entirely suggested by AI, please look this over.
c7c930f

Rsslone added 22 commits March 12, 2026 21:23
Fix the option being placed in the HEI menu. Placement under hide mode but likely will be moved later.
Add a group management screen to create and edit custom groups and toggle built in groups.
Moved the configuration buttons below the blacklist. One entry for bool enable for groups and one for the groups submenu.
While hide mode is enabled, we just expand all the collapsed entries.
Amend Enchanted Book to item name making it searchable in non-prefix search.
Fixed search result being applied to groups management page
Fixed enchanted book previews
Increased rows to 3
Removed ID string from display
Fixed GUI scaling on group management page.
Render 8 x 3 rows of icons, if overflow, -1 from last row and print + overflow count.
Simple drag selection
Allowing duplicate items in multiple groups. Not sure why people would want this, but its how REI does it too.
Changed the static list with overflow counter to a basic scrolling list. Scrollwheel and basic mouse drag support.
Implements searchable group names instead of only items within a group.
When a user presses "New Group" but goes back, the expected behavior is to cancel and not create a new group. Only save group on save.
Displays the first two items in a group, better indicating its a group. Changed the item count to a orange color, to better match the tooltip color and to stand out better. Decreased the size of the count.
Implement collapse on close, when HEI is closed collapse all currently open groups.
Implement Default Action, user selectable single click action, default to the more user friendly single click to expand group. Inverts Alt+Click action.
Fixed tooltips for closing expanded groups.
All translations were machine generated and cannot be validated with confidence. Take it with the grain of salt it deserves or leave it.
Implements an Alt+Click toggle to expand/collapse all groups via the HEI config button. Conditional tooltip to inform user. Includes translated keys.
Implement fluidstack in groups.
Implement single item groups act as itemstack.
Copy link
Member

@Rongmario Rongmario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick look and spotted something, CollapsedStack and CollapsibleEntry could be merged and to be a HEI "ingredient type", which can help compatibility.

Also where classes can be imported, should be imported.

Rsslone added 3 commits March 15, 2026 02:26
Merge CollapsedStack and CollapsibleEntry classes.
Registered CollapsedStack.TYPE
Changed CollapsedStack Ingredient Renderer to implement IIngredientRenderer<>
CollapsedStackIngredientHelper implements IIngredientHelper<>
CollapsedStackRenderer implements IIngredientRenderer<>
Implements wildcard selections item selector
Implements badges for wildcards
Implements orange tints for grouped items in other groups
Implements tooltips in item selector
@Rsslone Rsslone requested a review from Rongmario March 15, 2026 08:48
Fixed single item collapsed stack to return item tooltip instead of group tooltip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants