Udp.Code.Firewall sorting - #852
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the firewall result prioritization so that AntiCrawler/User-Agent blacklist decisions can outweigh SFW whitelist/trusted-network passes, by collecting all module results before deciding the final outcome.
Changes:
- Reordered
$statuses_priorityand introduced explicit PERSONAL-prefixed priority entries to control ordering between personal vs common SFW results. - Removed the early-exit whitelist break so all firewall modules run and contribute results before
prioritize()chooses the final status. - Refactored priority computation into a dedicated
calculatePriority()helper.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
|
|
||
| $this->isWhitelisted($results); |
There was a problem hiding this comment.
Not relevant
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #852 +/- ##
============================================
+ Coverage 27.71% 28.54% +0.82%
- Complexity 6079 6214 +135
============================================
Files 283 286 +3
Lines 25241 25667 +426
============================================
+ Hits 6996 7327 +331
- Misses 18245 18340 +95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
https://app.doboard.com/1/task/39195