Skip to content

return OK if backups for a VM are disabled#903

Open
fdriessler wants to merge 1 commit intoCheckmk:masterfrom
inettgmbh:proxmox-ve-vm-backup
Open

return OK if backups for a VM are disabled#903
fdriessler wants to merge 1 commit intoCheckmk:masterfrom
inettgmbh:proxmox-ve-vm-backup

Conversation

@fdriessler
Copy link
Contributor

General information

Affects: proxmox_ve_vm_backup_status

VMs with backups disabled return CRIT by default. As it is often intended to not backup VMs they shouldn't receive a CRIT warning by default.
I can understand why it could be beneficial to have CRIT for VMs where backups are disabled, but the warning should be created with dedicated text and be toggleable instead.
This PR currently only includes a change to not have the status be Critical for VMs with backups disabled.

Proposed changes

  • add a 'backup_enabled' field to the output generated by the special agent per VM
  • use the backup_enabled field to decide if no backups should cause a CRIT or OK Status

changes not in this PR that I could add if, as described above, VMs with backups disabled should return CRIT status:

  • Add a third option to the check if no backups are found that can be seperately toggled so that disabled backups either results in a CRIT or OK Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant