return OK if backups for a VM are disabled#903
Open
fdriessler wants to merge 1 commit intoCheckmk:masterfrom
Open
return OK if backups for a VM are disabled#903fdriessler wants to merge 1 commit intoCheckmk:masterfrom
fdriessler wants to merge 1 commit intoCheckmk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General information
Affects: proxmox_ve_vm_backup_status
VMs with backups disabled return CRIT by default. As it is often intended to not backup VMs they shouldn't receive a CRIT warning by default.
I can understand why it could be beneficial to have CRIT for VMs where backups are disabled, but the warning should be created with dedicated text and be toggleable instead.
This PR currently only includes a change to not have the status be Critical for VMs with backups disabled.
Proposed changes
changes not in this PR that I could add if, as described above, VMs with backups disabled should return CRIT status: