Fix CI regressions across Linux/macOS/Windows workflows#1
Open
CharlesHoskinson wants to merge 18 commits intomasterfrom
Open
Fix CI regressions across Linux/macOS/Windows workflows#1CharlesHoskinson wants to merge 18 commits intomasterfrom
CharlesHoskinson wants to merge 18 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nThis PR fixes the current CI failures observed on master across CI, PAL CI, Module DAG, and Sprint 2 Checks.\n\n### What was fixed\n- Fixed Linux/GCC C++23 gate false-negative by accepting GCC 13's __cplusplus=202100L in toolchain tests.\n- Added a concrete Linux update-checker factory implementation to resolve undefined symbol link failures.\n- Fixed Clang/macOS -Werror failures by removing anonymous struct-in-union declarations in internal/event types.\n- Fixed Clang/macOS -Wdefaulted-function-deleted by explicitly deleting non-movable HeadlessBackend move ops.\n- Fixed Clang/macOS tautological overflow-compare warnings in SAFE_MULTIPLY_OR_ERROR via size_t-normalized checks.\n- Fixed Windows SDL3 build/link failures by:\n - adding missing src/app/zmbv_codec.cpp and �ngine/src/libs/zmbv/zmbv_stubs.cpp to project_legends SDL3 target\n - copying SDL3.dll for Windows test binaries used by gtest_discover_tests (legends_unit_tests, legends_integration_tests).\n- Improved Clang job toolchain setup in ci.yml by installing g++-13 where Clang is used (matrix clang jobs, static analysis, fuzz, sanitizers).\n\n## Validation\n- Verified local Windows SDL3 configure/build for:\n - legends_toolchain_tests\n - legends_unit_tests\n - legends_integration_tests\n - project_legends\n- Confirmed prior Windows SDL3 unresolved externals and test-discovery runtime loader failures are resolved in local builds.\n